Fix for issue #109

DscResources/MSFT_WindowsPackageCab/MSFT_WindowsPackageCab.psm1

@@ -57,17 +57,17 @@ function Get-TargetResource
         Name = $Name
         Ensure = 'Present'
         SourcePath = $SourcePath
-        LogPath = $LogPath
     }
 
     $getWindowsPackageParams = @{
         PackageName = $Name
-        Online = $true
+        Online =  [switch]::Present
     }
 
     if ($PSBoundParameters.ContainsKey('LogPath'))
     {
         $getWindowsPackageParams['LogPath'] = $LogPath
+        $windowsPackageCab['LogPath'] = $LogPath
     }
 
     Write-Verbose -Message ($script:localizedData.RetrievingPackage -f $Name)
@@ -141,16 +141,26 @@ function Set-TargetResource
     {
         New-InvalidArgumentException -ArgumentName 'SourcePath' -Message ($script:localizedData.SourcePathDoesNotExist -f $SourcePath)
     }
+
+    $setTargetResourceParams = @{
+        PackagePath = $SourcePath
+        Online = [switch]::Present
+    }
+
+    if ($PSBoundParameters.ContainsKey('LogPath'))
+    {
+        $setTargetResourceParams['LogPath'] = $LogPath
+    }
 
     if ($Ensure -ieq 'Present')
     {
         Write-Verbose -Message ($script:localizedData.AddingPackage -f $SourcePath) 
-        Dism\Add-WindowsPackage -PackagePath $SourcePath -LogPath $LogPath -Online
+        Dism\Add-WindowsPackage @setTargetResourceParams
     }
     else
     {
         Write-Verbose -Message ($script:localizedData.RemovingPackage  -f $SourcePath)
-        Dism\Remove-WindowsPackage -PackagePath $SourcePath -LogPath $LogPath -Online
+        Dism\Remove-WindowsPackage @setTargetResourceParams
     }
 
     Write-Verbose -Message ($script:localizedData.SetTargetResourceFinished -f $Name)

README.md

@@ -577,6 +577,9 @@ The following parameters will be the same for each process in the set:
 
 ### Unreleased
 
+* WindowsPackageCab
+    * Made the LogPath parameter optional as it is supposed to be.
+
 ### 2.9.0.0
 
 * Added Description and Parameter description for composite resources

Tests/Unit/MSFT_WindowsPackageCab.Tests.ps1

@@ -70,6 +70,9 @@ try
                     $null = Get-TargetResource -Name $script:testPackageName -LogPath $script:testLogPath @getTargetResourceCommonParams
                     Assert-MockCalled -CommandName 'Dism\Get-WindowsPackage' -ParameterFilter { $LogPath -eq $script:testLogPath }
                 }
+                It 'Should not return a log path when it was not specified' {
+                    $null -eq (Get-TargetResource -Name $script:testPackageName @getTargetResourceCommonParams)['LogPath'] | Should be $true
+                }
             }
 
             Context 'Set-TargetResource' {
@@ -101,6 +104,14 @@ try
                     Set-TargetResource -Name $script:testPackageName -SourcePath $script:testSourcePath -Ensure 'Absent' -LogPath $script:testLogPath
                     Assert-MockCalled -CommandName 'Dism\Remove-WindowsPackage' -ParameterFilter { $LogPath -eq $script:testLogPath }
                 }
+                It 'Should not throw when a log path is not specified to Remove-WindowsPackage' {
+                    Set-TargetResource -Name $script:testPackageName -SourcePath $script:testSourcePath -Ensure 'Absent'
+                    Assert-MockCalled -CommandName 'Dism\Remove-WindowsPackage'  -ParameterFilter { $null -eq $LogPath }
+                }
+                It 'Should not throw when a log path is not specified to Add-WindowsPackage' {
+                    Set-TargetResource -Name $script:testPackageName -SourcePath $script:testSourcePath -Ensure 'Present'
+                    Assert-MockCalled -CommandName 'Dism\Add-WindowsPackage' -ParameterFilter { $null -eq $LogPath }
+                }
             }
 
             Context 'Test-TargetResource' {