NetworkDevice (NAD): Allow SNMP parameters #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alagoutte
changed the title
|
Hi @staley1975 Thanks for your contribution, it is possible to add some test (on Tests/integration/NetworkDevice.Tests.ps1) ? |
alagoutte
requested changes
Nov 17, 2023
…munity if snmp_version is set
|
can you also look for test ? may be also move example to the end (and use SW6 ?) |
|
Thanks, i will try and merge if it is ok |
Sounds good, and thank you for the feedback. |
Tested with 6.11 and 6.12 ! Working ! Thanks for your contribution, it will publish a new release on some next week... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows adding network devices (nads) with SNMP parameters, and setting SNMP parameters to existing network devices (nads)