Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Certificates function #44

Merged
merged 17 commits into from
Dec 8, 2023
Merged

Conversation

CedricMoreau
Copy link
Contributor

No description provided.

Copy link
Collaborator

@alagoutte alagoutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some fix


Return a list of cluster certificates on ClearPass

.EXAMPLE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align indent issue


Return the cluster certificate for service id 1 (RADIUS)

.EXAMPLE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent...

[int]$service_id,
[Parameter (Mandatory = $false)]
[Parameter (ParameterSetName = "name")]
[ValidateSet("RADIUS","HTTPS","RadSec")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have Visual Code Formatter for indent ?

$server = Get-ArubaCPServerConfiguration
$server_uuid = $server.server_uuid

$uri = "api/server-cert/name/ ${server_uuid}/${service_name}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space ?

Add a certificate on Clearpass for a service (HTTPS, RADIUS, RadSec)

.EXAMPLE
Add-ArubaCPServerCertificate -service_name HTTPS -cert_file <your_certificate>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What format for certificate ?

PowerArubaCP/Public/Certificate.ps1 Outdated Show resolved Hide resolved
PowerArubaCP/Public/Certificate.ps1 Outdated Show resolved Hide resolved
It "Get Cluster Certificates Does not throw an error" {
{
Get-ArubaCPClusterCertificates
} | Should Not Throw
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Pester v5 synthax => -Not -Throw


It "Get Cluster Certificates" {
$cc = Get-ArubaCPClusterCertificates
@($cc).count | Should not be $NULL
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Not -Be ...


It "Get Cluster Certificates with service_name Does not throw an error" {
{
Get-ArubaCPClusterCertificates -service_name "HTTPS(ECC)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have try with old release ? (of CPPM ?)

Copy link
Collaborator

@alagoutte alagoutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update

@alagoutte
Copy link
Collaborator

Need to change test also ?

@alagoutte alagoutte merged commit a8f7319 into PowerAruba:master Dec 8, 2023
1 check passed
@alagoutte
Copy link
Collaborator

Merci @CedricMoreau

Only remove add certificat (we can look after for add !)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants