-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Certificates function #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need some fix
PowerArubaCP/Public/Certificate.ps1
Outdated
|
||
Return a list of cluster certificates on ClearPass | ||
|
||
.EXAMPLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
align indent issue
PowerArubaCP/Public/Certificate.ps1
Outdated
|
||
Return the cluster certificate for service id 1 (RADIUS) | ||
|
||
.EXAMPLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent...
PowerArubaCP/Public/Certificate.ps1
Outdated
[int]$service_id, | ||
[Parameter (Mandatory = $false)] | ||
[Parameter (ParameterSetName = "name")] | ||
[ValidateSet("RADIUS","HTTPS","RadSec")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have Visual Code Formatter for indent ?
PowerArubaCP/Public/Certificate.ps1
Outdated
$server = Get-ArubaCPServerConfiguration | ||
$server_uuid = $server.server_uuid | ||
|
||
$uri = "api/server-cert/name/ ${server_uuid}/${service_name}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space ?
PowerArubaCP/Public/Certificate.ps1
Outdated
Add a certificate on Clearpass for a service (HTTPS, RADIUS, RadSec) | ||
|
||
.EXAMPLE | ||
Add-ArubaCPServerCertificate -service_name HTTPS -cert_file <your_certificate> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What format for certificate ?
It "Get Cluster Certificates Does not throw an error" { | ||
{ | ||
Get-ArubaCPClusterCertificates | ||
} | Should Not Throw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use Pester v5 synthax => -Not -Throw
|
||
It "Get Cluster Certificates" { | ||
$cc = Get-ArubaCPClusterCertificates | ||
@($cc).count | Should not be $NULL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-Not -Be ...
|
||
It "Get Cluster Certificates with service_name Does not throw an error" { | ||
{ | ||
Get-ArubaCPClusterCertificates -service_name "HTTPS(ECC)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have try with old release ? (of CPPM ?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update
…sts for get functions
1f31384
to
dd989af
Compare
Need to change test also ? |
Merci @CedricMoreau Only remove add certificat (we can look after for add !) |
No description provided.