Backport: fix: range request with 0 rows and 0 offset return status 416 #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I forgot about #3006 - should we rather back-patch that one? |
Added that one as well. |
wolfgangwalther
force-pushed
the
backport-range-requests
branch
from
35db906 to
f884da7
Compare
@wolfgangwalther Yeah, this is good. I also think it would play well with the branching strategy for docs |
|
There's another fix #3015 that we could backpatch but it's not critical at all. So I agree to backpatch with this single fix. |
steve-chavez
approved these changes
Oct 25, 2023
laurenceisla
approved these changes
Oct 25, 2023
|
Merged, pushed the tag and also adjusted the changelog on main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #2991 (comment) I suggest to back-patch #2991.
This is a PR towards the
rel-11.2branch. I renamed the branch fromrel-11.2.1torel-11.2. This makes more sense to be able to create PRs against a release branch to support backpatching bugfixes. The tag would still bev11.2.2ofc. I also renamed the otherrel-branches, @steve-chavez @laurenceisla.