Feature/filacms 23 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyoungportable
suggested changes
Apr 8, 2024
There was a problem hiding this comment.
Hi Jeremy,
Can you please add:
- validation for when the record is being updated, not just created (the user is able to change the slug)
- test cases for this new functionality
However, I'd suggest you look at the Filament docs for validation:
https://filamentphp.com/docs/3.x/forms/validation
If the user has entered a slug, we want them to experience an error, not just having a new number appended to the slug. We should only increment the slug if it's being autogenerated because of a blank slug.
kyoungportable
suggested changes
Apr 9, 2024
kyoungportable
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.