Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer to fix security vulnerabilities #198

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

jeremy-portable
Copy link
Collaborator

No description provided.

@sawks
Copy link
Contributor

sawks commented Nov 26, 2024

Hi @jeremy-portable - this commit is a bunch of formatting changes, not related to composer - is it required?

@sawks
Copy link
Contributor

sawks commented Nov 26, 2024

Please do an npm audit fix as well, which will update package-lock.json

@jeremy-portable
Copy link
Collaborator Author

Hi @jeremy-portable - this commit is a bunch of formatting changes, not related to composer - is it required?

Yes, however for some reason, the PHP Composer fails without it. I am also unsure as to why the formatting suddenly got triggered.

@Nirys
Copy link
Collaborator

Nirys commented Nov 26, 2024

Hi @jeremy-portable - this commit is a bunch of formatting changes, not related to composer - is it required?

@sawks / @jeremy-portable , it's because of the linting step. I'm kinda surprised it's not been a problem before. It's meant to enforce formatting standards.

Copy link
Contributor

@sawks sawks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets look into the linting stuff when we have some time, all good on the package updates

@sawks sawks merged commit f9a7c0d into main Nov 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants