Feat/allow taxonomies and terms to be reordered #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: show terms count for taxonomies wip: taxonomies should be reordered, but aren't fix: reinstated taxonomies list in navigation fix: taxonomy navigation icons are unique fix: nav isActiveWhen for taxonomies works fix: user-group icon for authors fix: hamburger icon for menu
jeremy-portable
requested review from
kyoungportable and
Kashkin
and removed request for
kyoungportable
jeric-portable
approved these changes
Oct 30, 2024
portable-tone
requested changes
Oct 30, 2024
portable-tone
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task is related to VG-394. For some reason, the reorder button shows up on terms but not on main taxonomy. This push fixes that along with Nick's original implementation. Also added a backward compatiblity condition on Taxonomy that uses the column "order" before it can even be imported.