test: 💍 fix leg-validations test

PolymeshAssociation · Nov 7, 2023 · a7bd03b · a7bd03b
1 parent eb9ac00
commit a7bd03b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/src/settlements/dto/leg-validation-params.dto.ts b/src/settlements/dto/leg-validation-params.dto.ts
@@ -16,18 +16,18 @@ export class LegValidationParamsDto {
   @ValidateIf(({ nfts }) => !nfts)
   @IsBigNumber()
   @ToBigNumber()
-  readonly amount: BigNumber;
+  readonly amount?: BigNumber;
 
   @ApiPropertyOptional({
     description: 'The NFT IDs to be transferred for the collection',
     type: 'string',
     isArray: true,
-    example: ['1000'],
+    example: ['1'],
   })
   @ValidateIf(({ amount }) => !amount)
   @IsBigNumber()
   @ToBigNumber()
-  readonly nfts: BigNumber[];
+  readonly nfts?: BigNumber[];
 
   @ApiProperty({
     description: 'DID of the sender',

diff --git a/src/settlements/settlements.service.spec.ts b/src/settlements/settlements.service.spec.ts
@@ -410,7 +410,7 @@ describe('SettlementsService', () => {
       const mockAsset = new MockAsset();
       mockAsset.settlements.canTransfer.mockResolvedValue(mockTransferBreakdown);
 
-      mockAssetsService.findFungible.mockResolvedValue(mockAsset);
+      mockAssetsService.findOne.mockResolvedValue(mockAsset);
 
       const result = await service.canTransfer(
         new PortfolioDto({ did: 'fromDid', id: new BigNumber(1) }).toPortfolioLike(),

diff --git a/src/settlements/settlements.service.ts b/src/settlements/settlements.service.ts
@@ -142,10 +142,12 @@ export class SettlementsService {
     from: PortfolioLike,
     to: PortfolioLike,
     ticker: string,
-    amount: BigNumber,
-    nfts: BigNumber[]
+    transferAmount?: BigNumber,
+    transferNfts?: BigNumber[]
   ): Promise<TransferBreakdown> {
     const assetDetails = await this.assetsService.findOne(ticker);
+    const amount = transferAmount ?? new BigNumber(0);
+    const nfts = transferNfts ?? [];
     return assetDetails.settlements.canTransfer({ from, to, amount, nfts });
   }