Mc testing to dev #7
reviewdog [flake8] report
reported by reviewdog 🐶
Findings (91)
tests/middleware/helper_functions.py|173 col 1| First line should be in imperative mood
tests/middleware/test_archives_queries.py|1 col 1| Missing docstring in public module
tests/middleware/test_archives_queries.py|8 col 1| 'tests.middleware.helper_functions.insert_test_agencies_and_sources' imported but unused
tests/middleware/test_archives_queries.py|12 col 1| 'tests.middleware.fixtures.dev_db_connection' imported but unused
tests/middleware/test_archives_queries.py|12 col 1| 'tests.middleware.fixtures.db_cursor' imported but unused
tests/middleware/test_archives_queries.py|12 col 1| 'tests.middleware.fixtures.connection_with_test_data' imported but unused
tests/middleware/test_archives_queries.py|20 col 5| redefinition of unused 'dev_db_connection' from line 12
tests/middleware/test_archives_queries.py|21 col 5| redefinition of unused 'db_cursor' from line 12
tests/middleware/test_archives_queries.py|23 col 1| 1 blank line required between summary line and description
tests/middleware/test_archives_queries.py|52 col 5| redefinition of unused 'connection_with_test_data' from line 12
tests/middleware/test_archives_queries.py|54 col 1| 1 blank line required between summary line and description
tests/middleware/test_archives_queries.py|54 col 1| First line should end with a period
tests/middleware/test_data_source_queries.py|1 col 1| Missing docstring in public module
tests/middleware/test_data_source_queries.py|4 col 1| 'tests.resources.app_test_data.DATA_SOURCES_ID_QUERY_RESULTS' imported but unused
tests/middleware/test_data_source_queries.py|18 col 1| 'tests.middleware.fixtures.connection_with_test_data' imported but unused
tests/middleware/test_data_source_queries.py|18 col 1| 'tests.middleware.fixtures.dev_db_connection' imported but unused
tests/middleware/test_data_source_queries.py|23 col 1| 1 blank line required between summary line and description
tests/middleware/test_data_source_queries.py|23 col 1| First line should end with a period
tests/middleware/test_data_source_queries.py|23 col 1| First line should be in imperative mood; try rephrasing
tests/middleware/test_data_source_queries.py|32 col 5| redefinition of unused 'connection_with_test_data' from line 18
tests/middleware/test_data_source_queries.py|35 col 1| 1 blank line required between summary line and description
tests/middleware/test_data_source_queries.py|35 col 1| First line should end with a period
tests/middleware/test_data_source_queries.py|54 col 5| redefinition of unused 'connection_with_test_data' from line 18
tests/middleware/test_data_source_queries.py|57 col 1| 1 blank line required between summary line and description
tests/middleware/test_data_source_queries.py|57 col 1| First line should end with a period
tests/middleware/test_data_source_queries.py|75 col 5| redefinition of unused 'connection_with_test_data' from line 18
tests/middleware/test_data_source_queries.py|77 col 1| 1 blank line required between summary line and description
tests/middleware/test_data_source_queries.py|77 col 1| First line should end with a period
tests/middleware/test_data_source_queries.py|96 col 5| redefinition of unused 'connection_with_test_data' from line 18
tests/middleware/test_data_source_queries.py|98 col 1| 1 blank line required between summary line and description
tests/middleware/test_data_source_queries.py|98 col 1| First line should end with a period
tests/middleware/test_data_source_queries.py|111 col 5| redefinition of unused 'connection_with_test_data' from line 18
tests/middleware/test_data_source_queries.py|114 col 1| 1 blank line required between summary line and description
tests/middleware/test_data_source_queries.py|114 col 1| First line should end with a period
tests/middleware/test_data_source_queries.py|135 col 5| redefinition of unused 'connection_with_test_data' from line 18
tests/middleware/test_data_source_queries.py|138 col 1| 1 blank line required between summary line and description
tests/middleware/test_data_source_queries.py|138 col 1| First line should end with a period
tests/middleware/test_login_queries.py|1 col 1| Missing docstring in public module
tests/middleware/test_login_queries.py|12 col 1| 'tests.middleware.fixtures.dev_db_connection' imported but unused
tests/middleware/test_login_queries.py|12 col 1| 'tests.middleware.fixtures.db_cursor' imported but unused
tests/middleware/test_login_queries.py|15 col 22| redefinition of unused 'db_cursor' from line 12
tests/middleware/test_login_queries.py|16 col 1| 1 blank line required between summary line and description
tests/middleware/test_login_queries.py|16 col 1| First line should end with a period
tests/middleware/test_login_queries.py|30 col 39| redefinition of unused 'db_cursor' from line 12
tests/middleware/test_login_queries.py|31 col 1| 1 blank line required between summary line and description
tests/middleware/test_login_queries.py|31 col 1| First line should end with a period
tests/middleware/test_login_queries.py|40 col 60| local variable 'mock_getenv' is assigned to but never used
tests/middleware/test_login_queries.py|47 col 19| redefinition of unused 'db_cursor' from line 12
tests/middleware/test_login_queries.py|48 col 1| 1 blank line required between summary line and description
tests/middleware/test_login_queries.py|48 col 1| First line should end with a period
tests/middleware/test_quick_search_query.py|1 col 1| Missing docstring in public module
tests/middleware/test_quick_search_query.py|1 col 1| 'datetime.datetime' imported but unused
tests/middleware/test_quick_search_query.py|4 col 1| 'pytz' imported but unused
tests/middleware/test_quick_search_query.py|11 col 1| 'tests.middleware.helper_functions.insert_test_agencies_and_sources' imported but unused
tests/middleware/test_quick_search_query.py|16 col 1| 'tests.middleware.fixtures.dev_db_connection' imported but unused
tests/middleware/test_quick_search_query.py|16 col 1| 'tests.middleware.fixtures.db_cursor' imported but unused
tests/middleware/test_quick_search_query.py|16 col 1| 'tests.middleware.fixtures.connection_with_test_data' imported but unused
tests/middleware/test_quick_search_query.py|24 col 5| redefinition of unused 'connection_with_test_data' from line 16
tests/middleware/test_quick_search_query.py|26 col 1| 1 blank line required between summary line and description
tests/middleware/test_quick_search_query.py|40 col 5| redefinition of unused 'connection_with_test_data' from line 16
tests/middleware/test_quick_search_query.py|42 col 1| First line should end with a period
tests/middleware/test_quick_search_query.py|66 col 5| redefinition of unused 'connection_with_test_data' from line 16
tests/middleware/test_quick_search_query.py|68 col 1| First line should end with a period
tests/middleware/test_reset_token_queries.py|1 col 1| Missing docstring in public module
tests/middleware/test_reset_token_queries.py|15 col 1| 'tests.middleware.fixtures.dev_db_connection' imported but unused
tests/middleware/test_reset_token_queries.py|15 col 1| 'tests.middleware.fixtures.db_cursor' imported but unused
tests/middleware/test_reset_token_queries.py|18 col 28| redefinition of unused 'db_cursor' from line 15
tests/middleware/test_reset_token_queries.py|19 col 1| 1 blank line required between summary line and description
tests/middleware/test_reset_token_queries.py|19 col 1| First line should end with a period
tests/middleware/test_reset_token_queries.py|31 col 26| redefinition of unused 'db_cursor' from line 15
tests/middleware/test_reset_token_queries.py|32 col 1| 1 blank line required between summary line and description
tests/middleware/test_reset_token_queries.py|32 col 1| First line should end with a period
tests/middleware/test_reset_token_queries.py|50 col 29| redefinition of unused 'db_cursor' from line 15
tests/middleware/test_reset_token_queries.py|51 col 1| 1 blank line required between summary line and description
tests/middleware/test_reset_token_queries.py|51 col 1| First line should end with a period
tests/middleware/test_user_queries.py|1 col 1| Missing docstring in public module
tests/middleware/test_user_queries.py|5 col 1| 'tests.middleware.fixtures.dev_db_connection' imported but unused
tests/middleware/test_user_queries.py|5 col 1| 'tests.middleware.fixtures.db_cursor' imported but unused
tests/middleware/test_user_queries.py|8 col 26| redefinition of unused 'db_cursor' from line 5
tests/middleware/test_user_queries.py|9 col 1| First line should end with a period
tests/middleware/test_user_queries.py|17 col 23| f-string is missing placeholders
tests/middleware/test_user_queries.py|23 col 27| redefinition of unused 'db_cursor' from line 5
tests/resources/app_test.py|1 col 1| Missing docstring in public module
tests/resources/app_test.py|19 col 1| Missing docstring in public function
tests/resources/app_test.py|25 col 1| Missing docstring in public function
tests/resources/app_test.py|30 col 1| Missing docstring in public function
tests/resources/app_test.py|35 col 1| Missing docstring in public function
tests/resources/app_test.py|52 col 1| Missing docstring in public function
tests/resources/app_test.py|58 col 1| Missing docstring in public function
tests/resources/app_test.py|64 col 1| Missing docstring in public function
tests/resources/app_test.py|160 col 1| Missing docstring in public function
Filtered Findings (180)
app.py|1 col 1| Missing docstring in public module
app.py|24 col 1| Missing docstring in public function
app.py|28 col 1| Missing docstring in public function
gunicorn_config.py|1 col 1| Missing docstring in public module
middleware/init.py|1 col 1| Missing docstring in public package
middleware/archives_queries.py|1 col 1| Missing docstring in public module
middleware/archives_queries.py|1 col 1| 'typing.Tuple' imported but unused
middleware/archives_queries.py|15 col 1| First line should end with a period
middleware/archives_queries.py|15 col 1| First line should be in imperative mood
middleware/archives_queries.py|43 col 1| First line should be in imperative mood
middleware/archives_queries.py|66 col 1| First line should be in imperative mood
middleware/archives_queries.py|83 col 1| First line should be in imperative mood
middleware/archives_queries.py|102 col 1| First line should be in imperative mood
middleware/data_source_queries.py|1 col 1| Missing docstring in public module
middleware/data_source_queries.py|1 col 1| 'typing.Tuple' imported but unused
middleware/data_source_queries.py|79 col 1| First line should be in imperative mood
middleware/data_source_queries.py|128 col 1| First line should be in imperative mood
middleware/data_source_queries.py|159 col 1| First line should be in imperative mood
middleware/data_source_queries.py|196 col 1| One-line docstring should fit on one line with quotes
middleware/data_source_queries.py|196 col 1| First line should end with a period
middleware/data_source_queries.py|196 col 1| First line should be in imperative mood
middleware/data_source_queries.py|220 col 1| One-line docstring should fit on one line with quotes
middleware/data_source_queries.py|220 col 1| First line should end with a period
middleware/data_source_queries.py|220 col 1| First line should be in imperative mood
middleware/data_source_queries.py|258 col 1| First line should be in imperative mood
middleware/initialize_psycopg2_connection.py|1 col 1| Missing docstring in public module
middleware/initialize_psycopg2_connection.py|10 col 1| 1 blank line required between summary line and description
middleware/initialize_psycopg2_connection.py|10 col 1| First line should end with a period
middleware/initialize_psycopg2_connection.py|10 col 1| First line should be in imperative mood
middleware/initialize_psycopg2_connection.py|30 col 5| do not use bare 'except'
middleware/login_queries.py|1 col 1| Missing docstring in public module
middleware/login_queries.py|9 col 1| First line should be in imperative mood
middleware/login_queries.py|32 col 1| First line should be in imperative mood
middleware/login_queries.py|52 col 1| First line should be in imperative mood
middleware/login_queries.py|75 col 1| First line should be in imperative mood
middleware/quick_search_query.py|1 col 1| Missing docstring in public module
middleware/quick_search_query.py|61 col 1| First line should be in imperative mood
middleware/quick_search_query.py|79 col 1| First line should be in imperative mood
middleware/quick_search_query.py|112 col 1| First line should be in imperative mood
middleware/quick_search_query.py|123 col 8| do not compare types, for exact checks use is
/ is not
, for instance checks use isinstance()
middleware/reset_token_queries.py|1 col 1| Missing docstring in public module
middleware/reset_token_queries.py|6 col 1| First line should be in imperative mood
middleware/reset_token_queries.py|29 col 1| First line should be in imperative mood
middleware/reset_token_queries.py|44 col 1| First line should be in imperative mood
middleware/security.py|1 col 1| Missing docstring in public module
middleware/security.py|2 col 1| 'hmac.compare_digest' imported but unused
middleware/security.py|3 col 1| 'flask.jsonify' imported but unused
middleware/security.py|7 col 1| 'os' imported but unused
middleware/security.py|9 col 1| 'flask.wrappers.Response' imported but unused
middleware/security.py|10 col 1| 'psycopg2.extensions.cursor as PgCursor' imported but unused
middleware/security.py|14 col 1| First line should be in imperative mood
middleware/security.py|71 col 1| 1 blank line required between summary line and description
middleware/security.py|71 col 1| First line should end with a period
middleware/security.py|71 col 1| First line should be in imperative mood; try rephrasing
middleware/user_queries.py|1 col 1| Missing docstring in public module
middleware/user_queries.py|7 col 1| First line should be in imperative mood
middleware/user_queries.py|24 col 1| First line should be in imperative mood
regular_api_checks.py|1 col 1| Missing docstring in public module
regular_api_checks.py|12 col 1| Missing docstring in public function
regular_api_checks.py|22 col 1| Missing docstring in public function
regular_api_checks.py|32 col 1| Missing docstring in public function
regular_api_checks.py|42 col 1| Missing docstring in public function
regular_api_checks.py|52 col 1| Missing docstring in public function
regular_api_checks.py|62 col 1| Missing docstring in public function
regular_api_checks.py|73 col 1| Missing docstring in public function
regular_api_checks.py|82 col 1| Missing docstring in public function
regular_api_checks.py|88 col 1| Missing docstring in public function
regular_api_checks.py|95 col 28| comparison to True should be 'if cond is True:' or 'if cond:'
regular_api_checks.py|98 col 1| Missing docstring in public function
regular_api_checks.py|108 col 1| Missing docstring in public function
regular_api_checks.py|114 col 9| line break before binary operator
regular_api_checks.py|118 col 1| Missing docstring in public function
regular_api_checks.py|127 col 1| Missing docstring in public function
regular_api_checks.py|134 col 1| Missing docstring in public function
regular_api_checks.py|140 col 1| Missing docstring in public function
regular_api_checks.py|148 col 1| Missing docstring in public function
regular_api_checks.py|158 col 1| Missing docstring in public function
regular_api_checks.py|169 col 1| Missing docstring in public function
regular_api_checks.py|179 col 1| Missing docstring in public function
regular_api_checks.py|194 col 1| Missing docstring in public function
regular_api_checks.py|210 col 1| Missing docstring in public function
regular_api_checks.py|227 col 1| Missing docstring in public function
regular_api_checks.py|238 col 1| Missing docstring in public function
regular_api_checks.py|244 col 1| Missing docstring in public function
regular_api_checks.py|262 col 1| Missing docstring in public function
regular_api_checks.py|281 col 1| Missing docstring in public function
regular_api_checks.py|287 col 1| Missing docstring in public function
regular_api_checks.py|294 col 1| Missing docstring in public function
regular_api_checks.py|325 col 30| comparison to True should be 'if cond is True:' or 'if cond:'
resources/Agencies.py|1 col 1| Missing docstring in public module
resources/Agencies.py|41 col 1| First line should be in imperative mood
resources/ApiKey.py|1 col 1| Missing docstring in public module
resources/ApiKey.py|14 col 1| First line should be in imperative mood
resources/Archives.py|1 col 1| Missing docstring in public module
resources/Archives.py|12 col 1| One-line docstring should fit on one line with quotes
resources/Archives.py|18 col 1| First line should be in imperative mood
resources/Archives.py|40 col 1| First line should be in imperative mood
resources/DataSources.py|1 col 1| Missing docstring in public module
resources/DataSources.py|13 col 1| 1 blank line required between summary line and description
resources/DataSources.py|20 col 1| First line should be in imperative mood
resources/DataSources.py|48 col 1| First line should be in imperative mood
resources/DataSources.py|72 col 24| do not compare types, for exact checks use is
/ is not
, for instance checks use isinstance()
resources/DataSources.py|97 col 1| 1 blank line required between summary line and description
resources/DataSources.py|104 col 1| First line should be in imperative mood
resources/DataSources.py|129 col 1| First line should be in imperative mood
resources/DataSources.py|152 col 24| do not compare types, for exact checks use is
/ is not
, for instance checks use isinstance()
resources/DataSources.py|178 col 1| Missing docstring in public class
resources/DataSources.py|181 col 1| Missing docstring in public method
resources/DataSources.py|201 col 1| 1 blank line required between summary line and description
resources/DataSources.py|208 col 1| First line should be in imperative mood
resources/Login.py|1 col 1| Missing docstring in public module
resources/Login.py|8 col 1| One-line docstring should fit on one line with quotes
resources/Login.py|13 col 1| 1 blank line required between summary line and description
resources/Login.py|13 col 1| First line should end with a period
resources/Login.py|13 col 1| First line should be in imperative mood
resources/PsycopgResource.py|1 col 1| Missing docstring in public module
resources/PsycopgResource.py|4 col 1| Missing docstring in public class
resources/PsycopgResource.py|6 col 1| 1 blank line required between summary line and description
resources/PsycopgResource.py|6 col 1| First line should be in imperative mood
resources/PsycopgResource.py|13 col 1| One-line docstring should fit on one line with quotes
resources/PsycopgResource.py|13 col 1| First line should be in imperative mood; try rephrasing
resources/PsycopgResource.py|19 col 1| One-line docstring should fit on one line with quotes
resources/PsycopgResource.py|19 col 1| First line should be in imperative mood; try rephrasing
resources/QuickSearch.py|1 col 1| Missing docstring in public module
resources/QuickSearch.py|14 col 1| 1 blank line required between summary line and description
resources/QuickSearch.py|14 col 1| First line should end with a period
resources/QuickSearch.py|23 col 1| 1 blank line required between summary line and description
resources/QuickSearch.py|23 col 1| First line should end with a period
resources/QuickSearch.py|23 col 1| First line should be in imperative mood
resources/QuickSearch.py|38 col 9| do not use bare 'except'
resources/QuickSearch.py|70 col 17| line break before binary operator
resources/QuickSearch.py|71 col 17| line break before binary operator
resources/QuickSearch.py|72 col 17| line break before binary operator
resources/QuickSearch.py|73 col 17| line break before binary operator
resources/QuickSearch.py|74 col 17| line break before binary operator
resources/RefreshSession.py|1 col 1| Missing docstring in public module
resources/RefreshSession.py|10 col 1| 1 blank line required between summary line and description
resources/RefreshSession.py|16 col 1| 1 blank line required between summary line and description
resources/RefreshSession.py|16 col 1| First line should end with a period
resources/RefreshSession.py|16 col 1| First line should be in imperative mood
resources/RequestResetPassword.py|1 col 1| Missing docstring in public module
resources/RequestResetPassword.py|13 col 1| 1 blank line required between summary line and description
resources/RequestResetPassword.py|13 col 1| First line should end with a period
resources/RequestResetPassword.py|19 col 1| 1 blank line required between summary line and description
resources/RequestResetPassword.py|19 col 1| First line should end with a period
resources/RequestResetPassword.py|19 col 1| First line should be in imperative mood
resources/RequestResetPassword.py|31 col 13| local variable 'id' is assigned to but never used
resources/RequestResetPassword.py|37 col 13| local variable 'r' is assigned to but never used
resources/ResetPassword.py|1 col 1| Missing docstring in public module
resources/ResetPassword.py|14 col 1| 1 blank line required between summary line and description
resources/ResetPassword.py|20 col 1| 1 blank line required between summary line and description
resources/ResetPassword.py|20 col 1| First line should end with a period
resources/ResetPassword.py|20 col 1| First line should be in imperative mood
resources/ResetTokenValidation.py|1 col 1| Missing docstring in public module
resources/ResetTokenValidation.py|10 col 1| Missing docstring in public class
resources/ResetTokenValidation.py|12 col 1| Missing docstring in public method
resources/SearchTokens.py|1 col 1| Missing docstring in public module
resources/SearchTokens.py|23 col 1| 1 blank line required between summary line and description
resources/SearchTokens.py|29 col 1| First line should be in imperative mood
resources/SearchTokens.py|48 col 16| do not compare types, for exact checks use is
/ is not
, for instance checks use isinstance()
resources/SearchTokens.py|55 col 17| f-string is missing placeholders
resources/SearchTokens.py|64 col 17| do not use bare 'except'
resources/SearchTokens.py|80 col 25| line break before binary operator
resources/SearchTokens.py|81 col 25| line break before binary operator
resources/SearchTokens.py|82 col 25| line break before binary operator
resources/SearchTokens.py|83 col 25| line break before binary operator
resources/SearchTokens.py|84 col 25| line break before binary operator
resources/User.py|1 col 1| Missing docstring in public module
resources/User.py|11 col 1| One-line docstring should fit on one line with quotes
resources/User.py|16 col 1| First line should be in imperative mood
resources/User.py|43 col 1| First line should be in imperative mood
resources/init.py|1 col 1| Missing docstring in public package
tests/init.py|1 col 1| Missing docstring in public package
tests/middleware/init.py|1 col 1| Missing docstring in public package
tests/resources/init.py|1 col 1| Missing docstring in public package
tests/resources/app_test_data.py|1 col 1| Missing docstring in public module
... (Too many findings. Dropped some findings)