Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mc 477 resource mass imports #212

Merged
merged 9 commits into from
Dec 9, 2024
Merged

Mc 477 resource mass imports #212

merged 9 commits into from
Dec 9, 2024

Conversation

maxachis
Copy link

@maxachis maxachis commented Dec 9, 2024

Fixes

Description

  • Add /batch endpoints for adding and updating data sources and agencies.
  • Refactor some existing logic to make this easier to perform

Testing

  • Run tests in tests directory, and confirm all function as expected
  • Inspect API and confirm presence of expected changes.

Performance

  • Batch endpoints are not batch-optimized -- each entry provided is performed in sequence, so the performance is roughly linear with the number of rows. It's unclear how this would perform with larger numbers of imports at a time.

Docs

  • /batch documentation provided.
  • One challenge is how to convey a proper csv template. At the moment, this is awkwardly conveyed via json documentation and a warning in the description to treat these as csv columns. A better solution could probably be determined.

Breaking Changes

  • No breaking changes.

@maxachis maxachis merged commit 9db28af into dev Dec 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant