Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mc pydantic #206

Merged
merged 5 commits into from
Dec 1, 2024
Merged

Mc pydantic #206

merged 5 commits into from
Dec 1, 2024

Conversation

maxachis
Copy link

@maxachis maxachis commented Dec 1, 2024

Fixes

Description

  • Begin adding comprehensive tests

LIBTYFI

  • Update /archives endpoint to align with current best practices for endpoint documentation and access logic
  • Update /permissions endpoint to align with current best practices for endpoint documentation and access logic
  • Clarify authorization checks to exit earlier on malformed requests
  • Add full test_bad_request_authorization and test_http_not_allowed
  • Update many internal models from dataclass to pydantic, which allows for more comprehensive type-checking

Testing

  • Run tests in tests directory, and confirm all function as expected
  • Inspect API and confirm presence of expected changes.

Performance

  • Comprehensive tests increase test overhead, but is designed to be run separately from other tests
  • Pydantic marginally increases internal logic overhead

Docs

  • API documentation updated

Breaking Changes

  • No breaking changes.

@maxachis
Begin updating models to Pydantic
e68f2cd
@maxachis
Complete updating models to Pydantic
142342f
@maxachis
Begin adding comprehensive tests
a16c51c 
LIBTYFI
- Update `/archives` endpoint to align with current best practices for endpoint documentation and access logic
- Update `/permissions` endpoint to align with current best practices for endpoint documentation and access logic
- Clarify authorization checks to exit earlier on malformed requests
- Add full `test_bad_request_authorization` and `test_http_not_allowed`
@maxachis maxachis merged commit 6df35b8 into dev Dec 1, 2024
11 checks passed
@maxachis maxachis deleted the mc_pydantic branch December 1, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-chamberlain josh-chamberlain Awaiting requested review from josh-chamberlain josh-chamberlain is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maxachis