Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic for automatically specifying last approval editor #179

Merged
merged 4 commits into from
Nov 16, 2024

Conversation

maxachis
Copy link

@maxachis maxachis commented Nov 16, 2024

Fixes

Description

  • A brief description of what this does. Include screenshots, if anything should change visually.

Testing

  • Run tests in tests directory and confirm functionality
  • Inspect API can confirm change to last_approval_editor definition in /data-sources GET as well as its absence in /data-sources PUT

Performance

  • Impact marginal

Docs

  • Accompanying docs PRs, if applicable

Breaking Changes

  • last_approval_editor can no longer be directly edited by the user.

@maxachis maxachis merged commit ab099ec into dev Nov 16, 2024
10 of 11 checks passed
@maxachis maxachis deleted the mc_499_automate_data_sources_last_approval_editor branch November 16, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant