Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mc 515 typeahead agencies include agency #173

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Mc 515 typeahead agencies include agency #173

merged 2 commits into from
Nov 14, 2024

Conversation

maxachis
Copy link

@maxachis maxachis commented Nov 14, 2024 •
edited
Loading

Fixes

Description

  • Include in id pull from /typeahead-agencies endpoint, as well as backend components and schema
  • Fix bugs in test data creation and deletion for related tests

Testing

  • Run tests in tests directory. Confirm functionality.
  • Confirm id included in API schema for /typeahead-agencies

Performance

  • Impact marginal

Docs

  • id key-value pair added to /typeahead-agencies

Breaking Changes

  • No breaking changes.

@maxachis maxachis merged commit 4a61304 into dev Nov 14, 2024
10 of 11 checks passed
@maxachis maxachis deleted the mc_515_typeahead_agencies_include_agency_id branch November 14, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-chamberlain josh-chamberlain Awaiting requested review from josh-chamberlain josh-chamberlain is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maxachis