Skip to content

Commit

Permalink
remove flaky tests that terminate before read. (apache#33371)
Browse files Browse the repository at this point in the history
Co-authored-by: lostluck <[email protected]>
  • Loading branch information
lostluck and lostluck authored Dec 13, 2024
1 parent a6061fe commit 011ec94
Showing 1 changed file with 0 additions and 28 deletions.
28 changes: 0 additions & 28 deletions sdks/go/pkg/beam/core/runtime/harness/datamgr_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -261,22 +261,6 @@ func TestElementChan(t *testing.T) {
return elms
},
wantSum: 6, wantCount: 3,
}, {
name: "FillBufferThenAbortThenRead",
sequenceFn: func(ctx context.Context, t *testing.T, client *fakeChanClient, c *DataChannel) <-chan exec.Elements {
for i := 0; i < bufElements+2; i++ {
client.Send(&fnpb.Elements{Data: []*fnpb.Elements_Data{dataElm(1, false)}})
}
elms := openChan(ctx, t, c, timerID)
c.removeInstruction(instID)

// These will be ignored
client.Send(&fnpb.Elements{Data: []*fnpb.Elements_Data{dataElm(1, false)}})
client.Send(&fnpb.Elements{Data: []*fnpb.Elements_Data{dataElm(2, false)}})
client.Send(&fnpb.Elements{Data: []*fnpb.Elements_Data{dataElm(3, true)}})
return elms
},
wantSum: bufElements, wantCount: bufElements,
}, {
name: "DataThenReaderThenLast",
sequenceFn: func(ctx context.Context, t *testing.T, client *fakeChanClient, c *DataChannel) <-chan exec.Elements {
Expand Down Expand Up @@ -389,18 +373,6 @@ func TestElementChan(t *testing.T) {
return elms
},
wantSum: 0, wantCount: 0,
}, {
name: "SomeTimersAndADataThenReaderThenCleanup",
sequenceFn: func(ctx context.Context, t *testing.T, client *fakeChanClient, c *DataChannel) <-chan exec.Elements {
client.Send(&fnpb.Elements{
Timers: []*fnpb.Elements_Timers{timerElm(1, false), timerElm(2, true)},
Data: []*fnpb.Elements_Data{dataElm(3, true)},
})
elms := openChan(ctx, t, c, timerID)
c.removeInstruction(instID)
return elms
},
wantSum: 6, wantCount: 3,
},
}
for _, test := range tests {
Expand Down

0 comments on commit 011ec94

Please sign in to comment.