Removed deprecated HeadingBias config in favor of GNSS aux lever arm specification. #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamshapiro0
force-pushed
the
heading-config
branch
from
f5f4ba5 to
bf2733e
Compare
axlan
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
In general seems fine. I would have some concern for backwards compatibility, but I don't think that should be a concern for a feature that probably hasn't had much active use (I don't think we need to worry about supporting devices running older firmware with this updated FE client library).
adamshapiro0
force-pushed
the
heading-config
branch
3 times, most recently
from
a02f37b to
29da9e3
Compare
adamshapiro0
force-pushed
the
heading-config
branch
from
e327f52 to
2cd422d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
GNSS_AUX_LEVER_ARM(secondary antenna) configuration settingChanges
HEADING_BIASconfiguration settingFixes
RawGNSSAttitudeOutputyaw/pitch printout