Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements for extract_position_data.py example script. #343

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Minor improvements for extract_position_data.py example script. #343

merged 3 commits into from
Nov 6, 2024

Conversation

adamshapiro0
Copy link
Collaborator

Changes

  • Use more common GNSSInfo messages instead of GNSSSatellite to determine SV count
  • Increased YPR and velocity precision in CSV file
  • Warn if the file does not contain any PoseAux (ENU velocity) or GNSSInfo (SV count) messages

@adamshapiro0 adamshapiro0 requested a review from wbrannon November 6, 2024 00:20
@adamshapiro0 adamshapiro0 self-assigned this Nov 6, 2024
axlan
axlan approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@axlan axlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wbrannon
wbrannon approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@wbrannon wbrannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@adamshapiro0 adamshapiro0 merged commit 06694af into master Nov 6, 2024
14 checks passed
@adamshapiro0 adamshapiro0 deleted the extract-pos branch November 6, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbrannon wbrannon wbrannon approved these changes

@axlan axlan axlan approved these changes

Assignees

@adamshapiro0 adamshapiro0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamshapiro0 @axlan @wbrannon