Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip empty files by default when searching for a p1log file. #321

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Skip empty files by default when searching for a p1log file. #321

merged 1 commit into from
Jun 11, 2024

Conversation

adamshapiro0
Copy link
Collaborator

Changes

  • Skip empty files by default in Python find_log_file() function

@adamshapiro0 adamshapiro0 requested a review from axlan June 6, 2024 20:22
@adamshapiro0 adamshapiro0 self-assigned this Jun 6, 2024
axlan
axlan approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@axlan axlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamshapiro0 adamshapiro0 merged commit e83c6ed into master Jun 11, 2024
14 checks passed
@adamshapiro0 adamshapiro0 deleted the skip-empty branch June 11, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axlan axlan axlan approved these changes

Assignees

@adamshapiro0 adamshapiro0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamshapiro0 @axlan