Add tool for filtering FE data in realtime. #318

axlan · 2024-05-22T22:57:11Z

New Features

Allow unknown MessageTypes to be specified as args
Tool to filter FusionEngine data over stdin

Fixes

Avoid error with empty fast_indexer results

adamshapiro0 · 2024-05-29T13:03:03Z

python/fusion_engine_client/messages/defs.py

-                int_val = int(pattern)
-                result.add(MessageType(int_val))
+                # Allow specifying unknown MessageType values if they are preceded by 'u'.
+                if len(pattern) > 1 and pattern[0] == 'u':


Is this u prefix really necessary? Any reason not to just treat any manually specified integer as "might be unknown and that's allowable"?

The thought was that 99% of the time an external customer would want to filter known messages and this would allow detecting typos. Other then that just assuming unknown is fine. Maybe the compromise would be to print a warning.

I think in practice this will just be an annoyance more than helpful. The majority of the time someone using this tool is probably going to be specifying message types by name, not number.

python/fusion_engine_client/applications/p1_filter.py

adamshapiro0

Looks good, just some minor cleanup for clarity.

axlan requested a review from adamshapiro0 May 22, 2024 22:57

axlan self-assigned this May 22, 2024

Add tool for filtering FE data in realtime.

f24a208

axlan force-pushed the p1-filter branch from eab0fe3 to f24a208 Compare May 22, 2024 22:59