Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add STARTUP_REQUEST as command message type #311

Merged
merged 2 commits into from
May 10, 2024
Merged

Add STARTUP_REQUEST as command message type #311

merged 2 commits into from
May 10, 2024

Conversation

wbrannon
Copy link
Contributor

@wbrannon wbrannon commented May 9, 2024

No description provided.

@wbrannon wbrannon added the bug Something isn't working label May 9, 2024
@wbrannon wbrannon requested a review from adamshapiro0 May 9, 2024 19:08
@wbrannon wbrannon self-assigned this May 9, 2024
@wbrannon wbrannon requested a review from axlan May 10, 2024 18:13
axlan
axlan approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@axlan axlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you should restructure the switch to give a warning if we add a new type without updating this function.

@wbrannon wbrannon force-pushed the fix-startup-command branch from bef54f4 to 79a235d Compare May 10, 2024 20:29
@wbrannon wbrannon merged commit 9c74676 into master May 10, 2024
14 checks passed
@wbrannon wbrannon deleted the fix-startup-command branch May 10, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axlan axlan axlan approved these changes

@adamshapiro0 adamshapiro0 Awaiting requested review from adamshapiro0

Assignees

@wbrannon wbrannon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbrannon @axlan