Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed handling of pose messages without GPS time when generating a KML file. #295

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Fixed handling of pose messages without GPS time when generating a KML file. #295

merged 3 commits into from
Feb 12, 2024

Conversation

adamshapiro0
Copy link
Collaborator

New Features

  • Added option to return Timestamp objects from convert_to_*_time() instead of just floating point values

Fixes

  • Fixed KML generation if any of the pose messages do not have GPS time, particularly after hot starting indoors

@adamshapiro0 adamshapiro0 requested a review from wbrannon February 1, 2024 14:26
@adamshapiro0 adamshapiro0 self-assigned this Feb 1, 2024
wbrannon
wbrannon approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@wbrannon wbrannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@adamshapiro0 adamshapiro0 merged commit 025c533 into master Feb 12, 2024
11 checks passed
@adamshapiro0 adamshapiro0 deleted the fix-kml-timestamps branch February 12, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbrannon wbrannon wbrannon approved these changes

Assignees

@adamshapiro0 adamshapiro0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamshapiro0 @wbrannon