Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added wheel speed input support to Python and resolved plotting issues. #286

Merged
merged 12 commits into from
Nov 21, 2023
Merged

Added wheel speed input support to Python and resolved plotting issues. #286

merged 12 commits into from
Nov 21, 2023

Conversation

adamshapiro0
Copy link
Collaborator

New Features

  • Added binary display options to p1_print (--format={binary, pretty-binary, oneline-binary})
  • Added missing WheelSpeedInput and VehicleSpeedInput Python classes

Changes

  • Separated wheel and vehicle speed/tick plotting to simplify code (only one should be present at a time)

Fixes

  • Clarified P1 vs system time in MeasurementDetails printout
  • Disregard user P1 time values in wheel/vehicle speed input messages
  • Fixed crash in binary_message_decode example when interpreting a SetConfig message

@adamshapiro0 adamshapiro0 requested a review from axlan November 13, 2023 15:40
@adamshapiro0 adamshapiro0 self-assigned this Nov 13, 2023
@adamshapiro0 adamshapiro0 force-pushed the wheel-input branch 2 times, most recently from 729e3d5 to ed9b756 Compare November 16, 2023 13:16
axlan
axlan approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@axlan axlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some clarification on the _plot_wheel_ticks_or_speeds would be good, by overall seems fine.

@adamshapiro0
Added missing vehicle/wheel speed input messages to Python.
e449160
@adamshapiro0
Print time source name and integer in MeasurementDetails printout.
d47784d
@adamshapiro0
Added p1_print --format={binary,pretty-binary,oneline-binary} options.
9f52679
@adamshapiro0
Trailing space cleanup.
089bdd6
@adamshapiro0
Print measurement time of reception as system time, not P1.
1956343
@adamshapiro0
Separated vehicle and wheel speed plots.
d102fdd 
This significantly simplifies the plotting logic. We still combine raw and
corrected measurements for vehicle or wheel data.
@adamshapiro0
Disregard user P1 times in wheel input measurements.
8d4ae98
@adamshapiro0
Clarified wheel tick->speed output rate behavior.
8192e9b
@adamshapiro0
Fixed crash in binary_message_decode example for SetConfig.
fa5f0b4
@adamshapiro0
Minor style cleanup.
6ef73b4
@adamshapiro0
Clarified wheel speed plot data loading conditions.
56a2f8c
@adamshapiro0
Refactored to separate corrected and raw wheel data completely in plot.
d294d6e
@adamshapiro0 adamshapiro0 merged commit cf6d76c into master Nov 21, 2023
12 checks passed
@adamshapiro0 adamshapiro0 deleted the wheel-input branch November 21, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axlan axlan axlan approved these changes

Assignees

@adamshapiro0 adamshapiro0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamshapiro0 @axlan