Fixed uint32 OverflowError on Windows. #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dtype=int` converts to the C `long` data type. On 64b Linux, that defaults to `int64_t`. On Windows however, even 64b, it is `int32_t`. Using `dtype=int` on Windows will raise an OverflowError when trying to convert uint32_t 0xFFFFFFFF values.
adamshapiro0
force-pushed
the
int-size
branch
from
a16a6b8 to
c41c444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
OverflowErroron Windows when trying to convert 0xFFFFFFFF to an integer numpy array