Make FileIndex flexible for different type keys. #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axlan
force-pushed
the
flexible-index-type
branch
from
0890b68 to
eb77310
Compare
| @@ -191,7 +195,7 @@ def load(self, index_path, data_path=None, delete_on_error=True): | |||
| if not os.path.exists(data_path): | |||
| # If the user didn't explicitly set data_path and the default file doesn't exist, it is not considered | |||
| # an error. | |||
| if self._data['type'][-1] == MessageType.INVALID: | |||
| if self._data['type'][-1] == self.enum_class.INVALID: | |||
There was a problem hiding this comment.
INVALID is just the name used by MessageType. Another enum might define a different value to use as an undefined/invalid value. Probably should pass this into the constructor too.
adamshapiro0
approved these changes
Sep 28, 2023
axlan
force-pushed
the
flexible-index-type
branch
from
49ec882 to
e8921c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.