Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed crash while plotting corrected vehicle/wheel speeds. #259

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Fixed crash while plotting corrected vehicle/wheel speeds. #259

merged 2 commits into from
Sep 22, 2023

Conversation

adamshapiro0
Copy link
Collaborator

Changes

  • Include measurement time/source in corrected measurement numpy output for API consistency with raw measurements
  • Renamed DOP figure to group with other GNSS figures

@adamshapiro0
Include measurement time/source in corrected measurement numpy output.
5862591 
That way, the corrected message have consistent fields with the matching raw
messages.

This fixes a crash when plotting corrected wheel/vehicle speeds instead of raw
(uncorrected).
@adamshapiro0
Renamed DOP figure to group with other GNSS figures.
48c1bad
@adamshapiro0 adamshapiro0 requested a review from axlan September 21, 2023 15:32
@adamshapiro0 adamshapiro0 self-assigned this Sep 21, 2023
axlan
axlan approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@axlan axlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamshapiro0 adamshapiro0 merged commit 771d5a5 into master Sep 22, 2023
14 checks passed
@adamshapiro0 adamshapiro0 deleted the corrected-meas branch September 22, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axlan axlan axlan approved these changes

Assignees

@adamshapiro0 adamshapiro0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamshapiro0 @axlan