Skip to content

Commit

Permalink
PR comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
Jonathan Diamond committed Sep 19, 2023
1 parent b50f3d4 commit 6f954ee
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
5 changes: 4 additions & 1 deletion python/fusion_engine_client/messages/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -1177,7 +1177,10 @@ def __init__(self, action: SaveAction = SaveAction.SAVE):
self.interfaces : List[InterfaceID] = []

def pack(self, buffer: bytes = None, offset: int = 0, return_buffer: bool = True) -> (bytes, int):
packed_data = self.SupportedIOInterfacesMessageConstruct.build(self.__dict__)
packed_data = self.SupportedIOInterfacesMessageConstruct.build({
'num_interfaces': len(self.interfaces),
'interfaces': self.interfaces
})
return PackedDataToBuffer(packed_data, buffer, offset, return_buffer)

def unpack(self, buffer: bytes, offset: int = 0, message_version: int = MessagePayload._UNSPECIFIED_VERSION) -> int:
Expand Down
6 changes: 4 additions & 2 deletions src/point_one/fusion_engine/messages/configuration.h
Original file line number Diff line number Diff line change
Expand Up @@ -2042,7 +2042,7 @@ struct P1_ALIGNAS(4) SupportedIOInterfacesMessage : public MessagePayload {

uint8_t reserved1[7] = {0};

/* This in then followed by an array of `num_interfaces` @ref InterfaceID */
/** This in then followed by an array of `num_interfaces` @ref InterfaceID. */
// InterfaceID interfaces[num_interfaces]
};

Expand Down Expand Up @@ -2105,7 +2105,9 @@ struct P1_ALIGNAS(4) MessageRateResponse : public MessagePayload {
/** The output interface corresponding with this response. */
InterfaceID output_interface = {};

/* This in then followed by an array of num_rates MessageRateResponseEntry */
/**
* This in then followed by an array of num_rates MessageRateResponseEntry.
*/
// MessageRateResponseEntry rates[num_rates]
};

Expand Down

0 comments on commit 6f954ee

Please sign in to comment.