Skip to content

Commit

Permalink
PR comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
Jonathan Diamond committed Jan 21, 2024
1 parent 2c1a186 commit 3cbefdc
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions python/fusion_engine_client/messages/control.py
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,7 @@ class ShutdownRequest(MessagePayload):
MESSAGE_TYPE = MessageType.SHUTDOWN_REQUEST
MESSAGE_VERSION = 0

## Stop navigation engine if running and flush calibration to non-volatile storage.
## Stop navigation engine and flush state to non-volatile storage.
STOP_ENGINE = 0x0000000000000001
## If a log is being generated, end that log.
STOP_CURRENT_LOG = 0x0000000000000002
Expand Down Expand Up @@ -685,7 +685,7 @@ class StartupRequest(MessagePayload):

## Start navigation engine if not running.
START_ENGINE = 0x0000000000000001
## If a log is not being generated, start a new log.
## If a log is not being generated, start a new log. If a log is active, end it, and immediately start a new log.
START_NEW_LOG = 0x0000000000000002

StartupRequestConstruct = Struct(
Expand Down
10 changes: 5 additions & 5 deletions src/point_one/fusion_engine/messages/control.h
Original file line number Diff line number Diff line change
Expand Up @@ -572,8 +572,7 @@ struct P1_ALIGNAS(4) ShutdownRequest : public MessagePayload {
static constexpr uint8_t MESSAGE_VERSION = 0;

/**
* Stop navigation engine if running and flush calibration to non-volatile
* storage.
* Stop navigation engine and flush state to non-volatile storage.
*/
static constexpr uint64_t STOP_ENGINE = 0x0000000000000001;
/**
Expand All @@ -585,7 +584,7 @@ struct P1_ALIGNAS(4) ShutdownRequest : public MessagePayload {
* A bitmask of flags associated with the event.
*
* @note For backwards compatibility, a value of `0` is treated as if the
* STOP_ENGINE bit is set (`0x0000000000000001`).
* @ref STOP_ENGINE bit is set (`0x0000000000000001`).
*/
uint64_t shutdown_flags = 0;
uint8_t reserved1[8] = {0};
Expand All @@ -609,15 +608,16 @@ struct P1_ALIGNAS(4) StartupRequest : public MessagePayload {
*/
static constexpr uint64_t START_ENGINE = 0x0000000000000001;
/**
* If a log is not being generated, start a new log.
* If a log is not being generated, start a new log. If a log is active, end
* it, and immediately start a new log.
*/
static constexpr uint64_t START_NEW_LOG = 0x0000000000000002;

/**
* A bitmask of flags associated with the event.
*
* @note For backwards compatibility, a value of `0` is treated as if the
* STOP_ENGINE bit is set (`0x0000000000000001`).
* @ref STOP_ENGINE bit is set (`0x0000000000000001`).
*/
uint64_t startup_flags = 0;
uint8_t reserved1[8] = {0};
Expand Down

0 comments on commit 3cbefdc

Please sign in to comment.