Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add span methods to all item types #49

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Add span methods to all item types #49

merged 2 commits into from
Jan 23, 2024

Conversation

PoignardAzur
Copy link
Owner

@PoignardAzur PoignardAzur commented Jan 20, 2024 •
edited
Loading

Fixes #46

@PoignardAzur PoignardAzur requested a review from Bromeon January 20, 2024 12:44
Bromeon
Bromeon approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! I was not feeling great with the direct access to private __span()...

@PoignardAzur PoignardAzur merged commit 9656201 into main Jan 23, 2024
3 checks passed
@Bromeon Bromeon deleted the add_spans branch January 23, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bromeon Bromeon Bromeon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement span() for each struct
2 participants
@PoignardAzur @Bromeon