-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppres huge size of icons in Manage questions in Moodle 4.5 #611
base: MOODLE_404_STABLE
Are you sure you want to change the base?
Conversation
Tested this PR #611 and I confirm that it works as expected. |
@@ -11,6 +11,10 @@ | |||
color: gray; | |||
} | |||
|
|||
#page-mod-questionnaire-questions .qcontainer .qnums ~ input[type=image] { | |||
max-height: 1em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
height: 1em; width: auto;
might be better
I adopted max-height to keep visual compatibility with prior versions but I doubt a little that it's the best.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello
I also have this same issue
I've tried
#page-mod-questionnaire-questions .qcontainer .qnums ~ input[type=image] {
max-height: 1em;
}
and
#page-mod-questionnaire-questions .qcontainer .qnums ~ input[type=image] {
height: 1em;
width: auto;
}
And it still occurs
Just to make sure, the idea is to edit the styles.css in the Questionnaire folder, correct?
I'm on questionnaire 4.1.1 (Build - 2024082900) and using Moodle 4.5
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried injecting it on Moodle as an additional HTML if you're using the stable version instead of my branch here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding that on additionalhtmlhead
Seems to have done the trick
Yeah, I still get a bit lost around the different versions one might encounter when using GIT, so that might not have helped
Thanks a lot for the help, I can finally do my testing without destroying my mouse scroll wheel 💪
I upgraded my Moodle to 4.5 and found the icons in Manage questions page are super huge.
It's due to the icons were changed from tiny raster ones to huge SVG ones in 4.5.
We now have to specify their size in CSS.
Fixes #612