Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use qualifier name for formatting conversion service #681

Conversation

pearsonradu
Copy link

@pearsonradu pearsonradu commented Sep 4, 2024

@pearsonradu pearsonradu force-pushed the qualified-formatting-conversion-service branch from ca5ebd8 to 58e183d Compare September 4, 2024 15:02
@kptfh kptfh force-pushed the qualified-formatting-conversion-service branch from 58e183d to 5109774 Compare September 4, 2024 15:48
@kptfh kptfh added the bug Something isn't working label Sep 4, 2024
- Use `feignConversionService` qualifier name for  `reactiveFeignContract` bean
- If qualified name is not used it will conflict with Spring's predefined conversion service
	- `Caused by: org.springframework.beans.factory.NoUniqueBeanDefinitionException: No qualifying bean of type 'org.springframework.format.support.FormattingConversionService' available: expected single matching bean but found 2: feignConversionService,webFluxConversionService`
	- See https://github.com/spring-projects/spring-boot/blob/f88f8f26fde93df292e1b50a490768058c67b127/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/reactive/WebFluxAutoConfiguration.java#L283
@kptfh kptfh force-pushed the qualified-formatting-conversion-service branch from 5109774 to 3263da2 Compare September 4, 2024 15:52
@kptfh kptfh merged commit 1278f4b into PlaytikaOSS:develop Sep 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants