First-pass conversion to classes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiamPattinson
approved these changes
Jul 6, 2023
ZedThree
force-pushed
the
convert-to-classes
branch
from
356c43c
to
a434a78
Compare
|
Rebased onto |
Codecov Report
@@ Coverage Diff @@
## main #2 +/- ##
==========================================
- Coverage 92.53% 91.25% -1.29%
==========================================
Files 2 2
Lines 67 80 +13
==========================================
+ Hits 62 73 +11
- Misses 5 7 +2
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough first pass at converting functions to classes. Free functions make more sense as interface, but using classes means we can do static type checking. These might be better as properties to make them read-only