-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TwoPowerProfile
#984
Merged
Merged
TwoPowerProfile
#984
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
abb028e
add PowerLawProfile class
daniel-dudt 992bbac
Merge branch 'master' into dd/power_law
ddudt ca0a878
clarify comment about when derivatives are infinite
daniel-dudt f7c8b79
Merge branch 'dd/power_law' of https://github.com/PlasmaControl/DESC …
daniel-dudt 0984615
Merge branch 'master' into dd/power_law
ddudt 85ac7b7
Merge branch 'master' into dd/power_law
ddudt 8a97669
rename to TwoPowerProfile
daniel-dudt ffabc90
add TwoPowerProfile to docs
daniel-dudt 60d3b11
add user warnings
daniel-dudt 4d9bb38
Merge branch 'master' into dd/power_law
ddudt f7937a6
change default params
daniel-dudt bb6cae0
add error tests
daniel-dudt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isnt this only true if b,c are floats <dr?
what is the use case for b,c being floats rather than ints?
my worry is also that if b<1 than the derivative blows up at r=0 as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, depending on the parameter values it may or may not blow up at$\rho=0$ and/or $\rho=1$ .
My personal use case is to use an integer
b
= 1 or 2, andc
as a float. But if these numbers are optimizable params they all need to be floats.Options:
b >= 1
. But there isn't much we can do aboutc
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My question is, do they all need to be optimizable? We could just make
b
,c
constant integers and leavea
optimizable?Along a similar vein, VMEC has a bunch of other profiles types that might be worth looking at: https://github.com/jonathanschilling/educational_VMEC/blob/master/src/profile_functions.f
I have some VMEC input files that use the atan and two-lorentz profiles that would be good to try in DESC.