Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Incompatible constraints to warn, add error if too large of a difference #931

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

dpanici
Copy link
Collaborator

@dpanici dpanici commented Mar 7, 2024

Resolves #921

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.95%. Comparing base (14b7636) to head (9d9ceb1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
- Coverage   94.96%   94.95%   -0.01%     
==========================================
  Files          83       83              
  Lines       20985    20991       +6     
==========================================
+ Hits        19928    19933       +5     
- Misses       1057     1058       +1     
Files Coverage Δ
desc/objectives/utils.py 92.39% <100.00%> (+0.53%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

github-actions bot commented Mar 7, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     +0.25 +/- 0.97     | +2.23e-05 +/- 8.76e-05 |  9.05e-03 +/- 7.4e-05  |  9.02e-03 +/- 4.7e-05  |
 test_build_transform_fft_midres         |     -1.30 +/- 1.52     | -1.14e-03 +/- 1.33e-03 |  8.65e-02 +/- 4.5e-04  |  8.76e-02 +/- 1.3e-03  |
 test_build_transform_fft_highres        |     -0.53 +/- 1.14     | -2.42e-03 +/- 5.24e-03 |  4.57e-01 +/- 3.2e-03  |  4.59e-01 +/- 4.2e-03  |
 test_equilibrium_init_lowres            |     -0.63 +/- 2.63     | -1.65e-03 +/- 6.90e-03 |  2.61e-01 +/- 1.9e-03  |  2.63e-01 +/- 6.6e-03  |
 test_equilibrium_init_medres            |     -0.96 +/- 1.68     | -5.79e-03 +/- 1.02e-02 |  5.99e-01 +/- 4.9e-03  |  6.05e-01 +/- 8.9e-03  |
 test_equilibrium_init_highres           |     +0.44 +/- 1.40     | +9.53e-03 +/- 3.04e-02 |  2.18e+00 +/- 2.0e-02  |  2.17e+00 +/- 2.3e-02  |
 test_objective_compile_dshape_current   |     -1.76 +/- 8.17     | -6.90e-02 +/- 3.19e-01 |  3.84e+00 +/- 2.2e-01  |  3.91e+00 +/- 2.4e-01  |
 test_objective_compile_atf              |     -1.75 +/- 5.29     | -1.35e-01 +/- 4.09e-01 |  7.61e+00 +/- 2.7e-01  |  7.74e+00 +/- 3.1e-01  |
 test_objective_compute_dshape_current   |     +2.34 +/- 2.09     | +1.22e-04 +/- 1.09e-04 |  5.34e-03 +/- 8.1e-05  |  5.22e-03 +/- 7.3e-05  |
 test_objective_compute_atf              |     -3.65 +/- 6.71     | -4.16e-04 +/- 7.66e-04 |  1.10e-02 +/- 2.4e-04  |  1.14e-02 +/- 7.3e-04  |
 test_objective_jac_dshape_current       |     -2.11 +/- 7.19     | -9.36e-04 +/- 3.18e-03 |  4.33e-02 +/- 2.0e-03  |  4.43e-02 +/- 2.5e-03  |
 test_objective_jac_atf                  |     -1.54 +/- 3.30     | -3.27e-02 +/- 7.00e-02 |  2.09e+00 +/- 6.3e-02  |  2.12e+00 +/- 3.0e-02  |
 test_perturb_1                          |     -3.07 +/- 4.48     | -4.33e-01 +/- 6.32e-01 |  1.37e+01 +/- 4.0e-01  |  1.41e+01 +/- 4.9e-01  |
 test_perturb_2                          |     +0.39 +/- 4.30     | +7.38e-02 +/- 8.12e-01 |  1.89e+01 +/- 7.3e-01  |  1.89e+01 +/- 3.6e-01  |
 test_proximal_jac_atf                   |     -0.49 +/- 0.94     | -3.49e-02 +/- 6.77e-02 |  7.15e+00 +/- 5.0e-02  |  7.18e+00 +/- 4.5e-02  |
 test_proximal_freeb_compute             |     -0.97 +/- 1.05     | -1.22e-03 +/- 1.32e-03 |  1.25e-01 +/- 1.3e-03  |  1.26e-01 +/- 3.7e-04  |
 test_proximal_freeb_jac                 |     -3.08 +/- 1.09     | -2.25e-01 +/- 7.94e-02 |  7.09e+00 +/- 5.4e-02  |  7.32e+00 +/- 5.8e-02  |

desc/objectives/utils.py Outdated Show resolved Hide resolved
@dpanici dpanici requested a review from f0uriest March 7, 2024 20:07
@dpanici dpanici added easy Short and simple to code or review EZ-review hackathon Stuff to work on during hackathon labels Mar 7, 2024
@YigitElma YigitElma merged commit b72cdca into master Mar 7, 2024
23 checks passed
@YigitElma YigitElma deleted the dp/warn-factorize-cons branch March 7, 2024 21:36
@YigitElma YigitElma mentioned this pull request May 1, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Short and simple to code or review hackathon Stuff to work on during hackathon
Projects
None yet
3 participants