Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to plot axis position to plot_boundaries #919

Merged
merged 3 commits into from
Mar 3, 2024
Merged

Conversation

f0uriest
Copy link
Member

@f0uriest f0uriest commented Mar 2, 2024

Resolves #787

@f0uriest f0uriest requested review from unalmis, dpanici and ddudt March 2, 2024 01:38
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (50e805d) to head (3ec9e21).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #919   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files          83       83           
  Lines       20980    20986    +6     
=======================================
+ Hits        19953    19959    +6     
  Misses       1027     1027           
Files Coverage Δ
desc/plotting.py 89.39% <100.00%> (+0.04%) ⬆️

Copy link
Contributor

github-actions bot commented Mar 2, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     +0.41 +/- 1.17     | +5.18e-05 +/- 1.48e-04 |  1.26e-02 +/- 1.2e-04  |  1.26e-02 +/- 8.8e-05  |
 test_build_transform_fft_midres         |     +0.83 +/- 0.92     | +7.66e-04 +/- 8.47e-04 |  9.32e-02 +/- 6.5e-04  |  9.24e-02 +/- 5.4e-04  |
 test_build_transform_fft_highres        |     +0.42 +/- 0.85     | +1.94e-03 +/- 3.95e-03 |  4.67e-01 +/- 3.3e-03  |  4.65e-01 +/- 2.1e-03  |
 test_equilibrium_init_lowres            |     +0.25 +/- 1.09     | +1.01e-03 +/- 4.47e-03 |  4.11e-01 +/- 4.0e-03  |  4.10e-01 +/- 2.1e-03  |
 test_equilibrium_init_medres            |     +1.67 +/- 1.77     | +1.27e-02 +/- 1.35e-02 |  7.75e-01 +/- 1.1e-02  |  7.62e-01 +/- 7.7e-03  |
 test_equilibrium_init_highres           |     +0.64 +/- 1.18     | +1.48e-02 +/- 2.72e-02 |  2.33e+00 +/- 1.9e-02  |  2.31e+00 +/- 1.9e-02  |
 test_objective_compile_dshape_current   |     +3.27 +/- 2.55     | +1.48e-01 +/- 1.15e-01 |  4.68e+00 +/- 1.1e-01  |  4.53e+00 +/- 3.1e-02  |
 test_objective_compile_atf              |     +2.51 +/- 2.24     | +2.29e-01 +/- 2.04e-01 |  9.33e+00 +/- 1.5e-01  |  9.10e+00 +/- 1.4e-01  |
 test_objective_compute_dshape_current   |     +0.84 +/- 2.37     | +5.82e-05 +/- 1.63e-04 |  6.95e-03 +/- 1.5e-04  |  6.89e-03 +/- 7.3e-05  |
 test_objective_compute_atf              |     +1.30 +/- 3.83     | +1.81e-04 +/- 5.31e-04 |  1.40e-02 +/- 5.2e-04  |  1.39e-02 +/- 1.2e-04  |
 test_objective_jac_dshape_current       |     +3.77 +/- 7.99     | +1.76e-03 +/- 3.73e-03 |  4.84e-02 +/- 2.2e-03  |  4.67e-02 +/- 3.0e-03  |
 test_objective_jac_atf                  |     +0.50 +/- 3.95     | +9.97e-03 +/- 7.94e-02 |  2.02e+00 +/- 5.5e-02  |  2.01e+00 +/- 5.7e-02  |
 test_perturb_1                          |     +0.35 +/- 5.78     | +4.77e-02 +/- 7.91e-01 |  1.37e+01 +/- 1.8e-01  |  1.37e+01 +/- 7.7e-01  |
 test_perturb_2                          |     -1.23 +/- 4.33     | -2.44e-01 +/- 8.57e-01 |  1.96e+01 +/- 2.4e-01  |  1.98e+01 +/- 8.2e-01  |
 test_proximal_jac_atf                   |     -2.08 +/- 1.53     | -1.42e-01 +/- 1.05e-01 |  6.72e+00 +/- 6.6e-02  |  6.86e+00 +/- 8.1e-02  |
+test_proximal_freeb_compute             |     -1.81 +/- 0.53     | -2.24e-03 +/- 6.54e-04 |  1.22e-01 +/- 5.3e-04  |  1.24e-01 +/- 3.8e-04  |
 test_proximal_freeb_jac                 |     -3.20 +/- 2.11     | -2.64e-01 +/- 1.75e-01 |  8.01e+00 +/- 5.8e-02  |  8.28e+00 +/- 1.7e-01  |

@f0uriest f0uriest merged commit ace5dbc into master Mar 3, 2024
17 checks passed
@f0uriest f0uriest deleted the rc/plot_axes branch March 3, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to plot axis location to plot_boundaries
2 participants