Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename eq method to equiv to avoid confusion with Equilibrium #917

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

f0uriest
Copy link
Member

@f0uriest f0uriest commented Mar 1, 2024

No description provided.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (4698f41) to head (38f8dfc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #917   +/-   ##
=======================================
  Coverage   95.05%   95.05%           
=======================================
  Files          83       83           
  Lines       20970    20970           
=======================================
  Hits        19934    19934           
  Misses       1036     1036           
Files Coverage Δ
desc/io/equilibrium_io.py 87.17% <100.00%> (ø)
desc/transform.py 90.88% <100.00%> (ø)
desc/utils.py 90.61% <100.00%> (ø)

Copy link
Contributor

github-actions bot commented Mar 1, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     +0.52 +/- 1.09     | +6.52e-05 +/- 1.37e-04 |  1.27e-02 +/- 1.0e-04  |  1.26e-02 +/- 8.8e-05  |
 test_build_transform_fft_midres         |     -0.08 +/- 1.14     | -7.15e-05 +/- 1.06e-03 |  9.23e-02 +/- 5.2e-04  |  9.23e-02 +/- 9.2e-04  |
 test_build_transform_fft_highres        |     +0.39 +/- 0.63     | +1.82e-03 +/- 2.93e-03 |  4.66e-01 +/- 2.1e-03  |  4.64e-01 +/- 2.1e-03  |
 test_equilibrium_init_lowres            |     +0.25 +/- 1.05     | +1.49e-03 +/- 6.24e-03 |  5.99e-01 +/- 4.2e-03  |  5.97e-01 +/- 4.6e-03  |
 test_equilibrium_init_medres            |     -0.26 +/- 1.46     | -3.25e-03 +/- 1.79e-02 |  1.23e+00 +/- 8.2e-03  |  1.23e+00 +/- 1.6e-02  |
 test_equilibrium_init_highres           |     -0.02 +/- 1.06     | -9.01e-04 +/- 4.39e-02 |  4.14e+00 +/- 2.2e-02  |  4.14e+00 +/- 3.8e-02  |
 test_objective_compile_dshape_current   |     -0.52 +/- 1.66     | -2.40e-02 +/- 7.62e-02 |  4.57e+00 +/- 4.1e-02  |  4.59e+00 +/- 6.4e-02  |
 test_objective_compile_atf              |     -0.17 +/- 4.26     | -1.55e-02 +/- 3.86e-01 |  9.05e+00 +/- 3.0e-01  |  9.06e+00 +/- 2.4e-01  |
 test_objective_compute_dshape_current   |     +0.28 +/- 2.98     | +1.79e-05 +/- 1.93e-04 |  6.50e-03 +/- 7.4e-05  |  6.48e-03 +/- 1.8e-04  |
 test_objective_compute_atf              |     +7.47 +/- 5.54     | +9.86e-04 +/- 7.31e-04 |  1.42e-02 +/- 7.1e-04  |  1.32e-02 +/- 1.8e-04  |
 test_objective_jac_dshape_current       |     -2.38 +/- 12.07    | -1.15e-03 +/- 5.83e-03 |  4.71e-02 +/- 3.8e-03  |  4.83e-02 +/- 4.4e-03  |
 test_objective_jac_atf                  |     +0.74 +/- 3.63     | +1.48e-02 +/- 7.22e-02 |  2.00e+00 +/- 5.3e-02  |  1.99e+00 +/- 4.9e-02  |
 test_perturb_1                          |     +3.05 +/- 3.43     | +4.03e-01 +/- 4.54e-01 |  1.36e+01 +/- 4.3e-01  |  1.32e+01 +/- 1.4e-01  |
 test_perturb_2                          |     +1.68 +/- 1.52     | +3.19e-01 +/- 2.89e-01 |  1.94e+01 +/- 2.5e-01  |  1.90e+01 +/- 1.5e-01  |
 test_proximal_jac_atf                   |     +0.41 +/- 1.13     | +2.77e-02 +/- 7.57e-02 |  6.73e+00 +/- 5.8e-02  |  6.70e+00 +/- 4.9e-02  |
 test_proximal_freeb_compute             |     +0.18 +/- 0.87     | +2.21e-04 +/- 1.06e-03 |  1.21e-01 +/- 8.7e-04  |  1.21e-01 +/- 6.0e-04  |
 test_proximal_freeb_jac                 |     +0.13 +/- 1.75     | +1.05e-02 +/- 1.39e-01 |  7.97e+00 +/- 1.3e-01  |  7.96e+00 +/- 5.4e-02  |

@f0uriest f0uriest merged commit 70001bc into master Mar 2, 2024
19 checks passed
@f0uriest f0uriest deleted the rc/equals branch March 3, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants