Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jvp signature for Objective #909

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Fix jvp signature for Objective #909

merged 3 commits into from
Feb 29, 2024

Conversation

f0uriest
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (569d35e) to head (99ff2e2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #909   +/-   ##
=======================================
  Coverage   95.05%   95.05%           
=======================================
  Files          83       83           
  Lines       20962    20966    +4     
=======================================
+ Hits        19925    19929    +4     
  Misses       1037     1037           
Files Coverage Δ
desc/objectives/objective_funs.py 93.20% <100.00%> (+0.04%) ⬆️

Copy link
Contributor

github-actions bot commented Feb 28, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     -0.24 +/- 1.55     | -3.08e-05 +/- 1.96e-04 |  1.26e-02 +/- 1.4e-04  |  1.27e-02 +/- 1.4e-04  |
 test_build_transform_fft_midres         |     +1.41 +/- 1.39     | +1.28e-03 +/- 1.27e-03 |  9.26e-02 +/- 1.0e-03  |  9.13e-02 +/- 7.2e-04  |
 test_build_transform_fft_highres        |     +0.35 +/- 0.97     | +1.58e-03 +/- 4.44e-03 |  4.59e-01 +/- 3.5e-03  |  4.57e-01 +/- 2.7e-03  |
 test_equilibrium_init_lowres            |     +1.30 +/- 2.00     | +7.72e-03 +/- 1.18e-02 |  6.01e-01 +/- 1.1e-02  |  5.93e-01 +/- 3.4e-03  |
 test_equilibrium_init_medres            |     -0.64 +/- 2.65     | -7.98e-03 +/- 3.31e-02 |  1.24e+00 +/- 2.2e-02  |  1.25e+00 +/- 2.4e-02  |
 test_equilibrium_init_highres           |     -0.31 +/- 1.02     | -1.28e-02 +/- 4.25e-02 |  4.13e+00 +/- 3.4e-02  |  4.15e+00 +/- 2.6e-02  |
 test_objective_compile_dshape_current   |     -2.00 +/- 1.94     | -9.43e-02 +/- 9.14e-02 |  4.61e+00 +/- 7.0e-02  |  4.70e+00 +/- 5.9e-02  |
 test_objective_compile_atf              |     +0.80 +/- 3.37     | +7.34e-02 +/- 3.11e-01 |  9.30e+00 +/- 2.4e-01  |  9.23e+00 +/- 1.9e-01  |
 test_objective_compute_dshape_current   |     +8.76 +/- 7.11     | +5.94e-04 +/- 4.82e-04 |  7.37e-03 +/- 2.7e-04  |  6.78e-03 +/- 4.0e-04  |
 test_objective_compute_atf              |     +4.17 +/- 3.46     | +5.53e-04 +/- 4.58e-04 |  1.38e-02 +/- 3.4e-04  |  1.33e-02 +/- 3.1e-04  |
 test_objective_jac_dshape_current       |     -3.16 +/- 7.37     | -1.48e-03 +/- 3.45e-03 |  4.54e-02 +/- 2.3e-03  |  4.69e-02 +/- 2.6e-03  |
 test_objective_jac_atf                  |     +1.82 +/- 2.92     | +3.63e-02 +/- 5.82e-02 |  2.03e+00 +/- 4.6e-02  |  2.00e+00 +/- 3.5e-02  |
 test_perturb_1                          |     -2.02 +/- 2.56     | -2.77e-01 +/- 3.50e-01 |  1.34e+01 +/- 1.9e-01  |  1.37e+01 +/- 3.0e-01  |
 test_perturb_2                          |     +1.76 +/- 2.88     | +3.40e-01 +/- 5.55e-01 |  1.97e+01 +/- 5.4e-01  |  1.93e+01 +/- 1.3e-01  |
 test_proximal_jac_atf                   |     +0.02 +/- 1.16     | +1.19e-03 +/- 7.84e-02 |  6.76e+00 +/- 3.6e-02  |  6.76e+00 +/- 7.0e-02  |
 test_proximal_freeb_compute             |     +0.00 +/- 1.66     | +4.55e-06 +/- 2.03e-03 |  1.23e-01 +/- 1.8e-03  |  1.23e-01 +/- 1.0e-03  |
 test_proximal_freeb_jac                 |     +0.11 +/- 1.83     | +9.01e-03 +/- 1.47e-01 |  8.05e+00 +/- 8.9e-02  |  8.04e+00 +/- 1.2e-01  |

Copy link
Collaborator

@rahulgaur104 rahulgaur104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on dd/omnigenity now. Merge if all tests have passed!

@f0uriest f0uriest merged commit 664a562 into master Feb 29, 2024
17 checks passed
@f0uriest f0uriest deleted the rc/hotfix branch February 29, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants