Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bounding Box to Field Line Integration #908
Add Bounding Box to Field Line Integration #908
Changes from 9 commits
20cc578
aa65b19
5a72566
192b911
2e23181
18102b9
96fb8a9
bf02799
1463fed
01fc1f5
4abd4e4
5261613
329d3f0
7e48dbc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 1439 in desc/magnetic_fields.py
Codecov / codecov/patch
desc/magnetic_fields.py#L1439
Check warning on line 1444 in desc/magnetic_fields.py
Codecov / codecov/patch
desc/magnetic_fields.py#L1444
Check warning on line 1467 in desc/magnetic_fields.py
Codecov / codecov/patch
desc/magnetic_fields.py#L1467
Check warning on line 1472 in desc/magnetic_fields.py
Codecov / codecov/patch
desc/magnetic_fields.py#L1472
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't expect the integration to stop immediately after the bound is exited, but it should stop soon after depending on how fast the RHS decays. I made the decay very fast so we can test it, but if for some reason we should lessen the decay rates, then we will need to make these test tols here less tight