Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FourierRZCurveWindingSurface Class #844

Draft
wants to merge 47 commits into
base: master
Choose a base branch
from

Merge branch 'master' into dp/curve-winding-surface

982cedd
Select commit
Loading
Failed to load commit list.
Draft

Implement FourierRZCurveWindingSurface Class #844

Merge branch 'master' into dp/curve-winding-surface
982cedd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 11, 2024 in 1s

91.34% (-4.11%) compared to acc8e5a

View this Pull Request on Codecov

91.34% (-4.11%) compared to acc8e5a

Details

Codecov Report

Attention: Patch coverage is 94.94949% with 15 lines in your changes missing coverage. Please review.

Project coverage is 91.34%. Comparing base (acc8e5a) to head (982cedd).

Files with missing lines Patch % Lines
desc/geometry/curve.py 94.67% 9 Missing ⚠️
desc/compute/_curve.py 96.52% 4 Missing ⚠️
desc/compute/utils.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
- Coverage   95.44%   91.34%   -4.11%     
==========================================
  Files          95       95              
  Lines       23402    23697     +295     
==========================================
- Hits        22336    21645     -691     
- Misses       1066     2052     +986     
Files with missing lines Coverage Δ
desc/coils.py 95.74% <100.00%> (-1.72%) ⬇️
desc/compute/_core.py 96.63% <100.00%> (-3.37%) ⬇️
desc/compute/data_index.py 97.22% <ø> (ø)
desc/geometry/__init__.py 100.00% <100.00%> (ø)
desc/compute/utils.py 96.15% <50.00%> (-0.74%) ⬇️
desc/compute/_curve.py 94.26% <96.52%> (-5.74%) ⬇️
desc/geometry/curve.py 94.56% <94.67%> (-1.44%) ⬇️

... and 40 files with indirect coverage changes