Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix norm bug in curvature computation #566

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Fix norm bug in curvature computation #566

merged 3 commits into from
Jul 5, 2023

Conversation

unalmis
Copy link
Collaborator

@unalmis unalmis commented Jul 4, 2023

Looks like the matrix norm was being computed instead of the vector norm for normal vector of a rho surface. Affects all curvature quantities. Might be a good idea to review other places we use norm. grep -r -F 'np.linalg.norm'

@unalmis unalmis requested a review from f0uriest July 4, 2023 01:42
@unalmis unalmis marked this pull request as ready for review July 4, 2023 01:42
@unalmis unalmis requested a review from ddudt July 4, 2023 01:45
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (00d255e) 94.16% compared to head (777599f) 94.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
- Coverage   94.16%   94.15%   -0.02%     
==========================================
  Files          75       75              
  Lines       16963    16951      -12     
==========================================
- Hits        15973    15960      -13     
- Misses        990      991       +1     
Impacted Files Coverage Δ
desc/compute/_geometry.py 100.00% <ø> (ø)
desc/compute/_basis_vectors.py 100.00% <100.00%> (ø)
desc/compute/_field.py 100.00% <100.00%> (ø)
desc/plotting.py 87.31% <100.00%> (-0.08%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@f0uriest f0uriest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I had realized recently that n and n_rho were duplicated. I'd prefer to keep the name n_rho to avoid confusion with other normal vectors, other than that looks good.

@unalmis unalmis merged commit 80f5154 into master Jul 5, 2023
@unalmis unalmis deleted the norm_bug branch July 5, 2023 18:01
@unalmis unalmis added the bug fix Something was fixed label Jul 22, 2024
@unalmis unalmis self-assigned this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Something was fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants