Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebooks with new stopping criteria #1425

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

f0uriest
Copy link
Member

@f0uriest f0uriest commented Dec 4, 2024

Updates all the notebooks with new stopping criteria and new example equilibria (and misc other changes since they were last ran forever ago). No significant changes, just some small numerical differences in a few places.

Resolves #1423
Resolves #1468

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@f0uriest f0uriest added the skip_changelog No need to update changelog on this PR label Dec 4, 2024
@f0uriest f0uriest marked this pull request as draft December 4, 2024 04:52
@f0uriest f0uriest changed the base branch from rc/stopping_criteria to rc/examples December 4, 2024 23:58
@f0uriest f0uriest deleted the branch master December 11, 2024 23:08
@f0uriest f0uriest closed this Dec 11, 2024
@f0uriest f0uriest reopened this Dec 11, 2024
@f0uriest f0uriest changed the base branch from rc/examples to master December 11, 2024 23:12
@f0uriest f0uriest mentioned this pull request Dec 13, 2024
@f0uriest f0uriest marked this pull request as ready for review December 14, 2024 01:10
Copy link

review-notebook-app bot commented Dec 14, 2024

View / edit / reply to this conversation on ReviewNB

YigitElma commented on 2024-12-14T04:12:56Z
----------------------------------------------------------------

Line #81.        maxiter=10,  # increase maxiter to 50 for a better result

I guess these changes make the execution of the cell over the threshold 2000 seconds for CI. If it doesn't change the result too much, we can keep it at low maxiter and keep the comment.


Copy link
Collaborator

@YigitElma YigitElma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For CI's sake, we might need to reduce the maxiter for ballooning notebook.

@f0uriest f0uriest requested review from a team, rahulgaur104, ddudt, dpanici, kianorr and sinaatalay and removed request for a team December 17, 2024 22:21
@YigitElma
Copy link
Collaborator

YigitElma commented Dec 20, 2024

I am note sure if it is caused a difference but, since we are at, should we rerun them after #1363 ? Let me know, I can run them again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_changelog No need to update changelog on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in documentation for Newcomb's metric Re-run example notebooks with updated stopping criteria
3 participants