-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notebooks with new stopping criteria #1425
base: master
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
View / edit / reply to this conversation on ReviewNB YigitElma commented on 2024-12-14T04:12:56Z Line #81. maxiter=10, # increase maxiter to 50 for a better result I guess these changes make the execution of the cell over the threshold 2000 seconds for CI. If it doesn't change the result too much, we can keep it at low maxiter and keep the comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For CI's sake, we might need to reduce the maxiter for ballooning notebook.
I am note sure if it is caused a difference but, since we are at, should we rerun them after #1363 ? Let me know, I can run them again! |
Updates all the notebooks with new stopping criteria and new example equilibria (and misc other changes since they were last ran forever ago). No significant changes, just some small numerical differences in a few places.
Resolves #1423
Resolves #1468