-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support numpy 2.0
#1319
Support numpy 2.0
#1319
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1319 +/- ##
=======================================
Coverage 95.51% 95.51%
=======================================
Files 96 96
Lines 24047 24047
=======================================
Hits 22969 22969
Misses 1078 1078
|
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_midres | -2.04 +/- 6.38 | -1.25e-02 +/- 3.93e-02 | 6.03e-01 +/- 2.4e-02 | 6.16e-01 +/- 3.1e-02 |
test_build_transform_fft_highres | +0.15 +/- 4.22 | +1.40e-03 +/- 4.06e-02 | 9.64e-01 +/- 2.2e-02 | 9.62e-01 +/- 3.4e-02 |
test_equilibrium_init_lowres | -1.53 +/- 4.96 | -6.01e-02 +/- 1.95e-01 | 3.87e+00 +/- 8.8e-02 | 3.93e+00 +/- 1.7e-01 |
test_objective_compile_atf | -0.69 +/- 4.52 | -5.45e-02 +/- 3.57e-01 | 7.83e+00 +/- 2.7e-01 | 7.89e+00 +/- 2.3e-01 |
test_objective_compute_atf | -3.63 +/- 4.20 | -3.92e-04 +/- 4.53e-04 | 1.04e-02 +/- 1.3e-04 | 1.08e-02 +/- 4.3e-04 |
test_objective_jac_atf | -0.82 +/- 3.79 | -1.57e-02 +/- 7.28e-02 | 1.91e+00 +/- 5.2e-02 | 1.92e+00 +/- 5.1e-02 |
test_perturb_1 | -1.06 +/- 4.92 | -1.36e-01 +/- 6.34e-01 | 1.27e+01 +/- 3.1e-01 | 1.29e+01 +/- 5.5e-01 |
test_proximal_jac_atf | -0.06 +/- 0.88 | -4.84e-03 +/- 7.20e-02 | 8.20e+00 +/- 5.7e-02 | 8.20e+00 +/- 4.4e-02 |
test_proximal_freeb_compute | -1.87 +/- 1.45 | -3.49e-03 +/- 2.70e-03 | 1.83e-01 +/- 1.3e-03 | 1.87e-01 +/- 2.4e-03 |
test_build_transform_fft_lowres | -0.28 +/- 9.27 | -1.46e-03 +/- 4.92e-02 | 5.30e-01 +/- 4.3e-02 | 5.31e-01 +/- 2.5e-02 |
test_equilibrium_init_medres | +0.44 +/- 1.40 | +1.82e-02 +/- 5.83e-02 | 4.17e+00 +/- 4.4e-02 | 4.15e+00 +/- 3.8e-02 |
test_equilibrium_init_highres | -0.14 +/- 1.67 | -7.69e-03 +/- 9.12e-02 | 5.44e+00 +/- 7.1e-02 | 5.45e+00 +/- 5.7e-02 |
test_objective_compile_dshape_current | +0.79 +/- 1.84 | +3.07e-02 +/- 7.14e-02 | 3.91e+00 +/- 4.7e-02 | 3.88e+00 +/- 5.4e-02 |
test_objective_compute_dshape_current | +5.20 +/- 1.86 | +1.89e-04 +/- 6.78e-05 | 3.83e-03 +/- 4.7e-05 | 3.64e-03 +/- 4.9e-05 |
test_objective_jac_dshape_current | -0.73 +/- 7.48 | -3.05e-04 +/- 3.13e-03 | 4.15e-02 +/- 1.9e-03 | 4.19e-02 +/- 2.5e-03 |
test_perturb_2 | +0.10 +/- 1.80 | +1.73e-02 +/- 3.20e-01 | 1.78e+01 +/- 1.4e-01 | 1.78e+01 +/- 2.9e-01 |
test_proximal_freeb_jac | -0.14 +/- 1.13 | -1.02e-02 +/- 8.50e-02 | 7.51e+00 +/- 3.9e-02 | 7.52e+00 +/- 7.5e-02 |
test_solve_fixed_iter | -1.42 +/- 58.93 | -7.34e-02 +/- 3.04e+00 | 5.08e+00 +/- 2.1e+00 | 5.15e+00 +/- 2.2e+00 | |
My bad, to test |
I'll try to do that tomorrow or Friday |
No worries, I just wanted to test if it works or not. |
Temporarily changing the tests to use whatever matplotlib is installed in the first place. Downgrading to 3.7.2 causes tests to immediately fail. |
Apparently, we get some |
This might change our |
The command in CONTRIBUTING.rst doesn't work even for master. |
|
This was overlooked in #1319 , I think, which changed the scipy requirement to remove the `<2.0` in `requirements.txt` but not anywhere else
No description provided.