Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixOmniBmax bug fix #1268

Merged
merged 7 commits into from
Sep 30, 2024
Merged

FixOmniBmax bug fix #1268

merged 7 commits into from
Sep 30, 2024

Conversation

ddudt
Copy link
Collaborator

@ddudt ddudt commented Sep 25, 2024

Resolves #1266

@ddudt ddudt added the bug fix Something was fixed label Sep 25, 2024
@ddudt ddudt self-assigned this Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.44%. Comparing base (c2bb798) to head (f60e33f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1268   +/-   ##
=======================================
  Coverage   95.44%   95.44%           
=======================================
  Files          96       96           
  Lines       23791    23791           
=======================================
  Hits        22708    22708           
  Misses       1083     1083           
Files with missing lines Coverage Δ
desc/objectives/linear_objectives.py 97.05% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

github-actions bot commented Sep 25, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     +0.40 +/- 6.98     | +2.16e-03 +/- 3.74e-02 |  5.39e-01 +/- 2.9e-02  |  5.36e-01 +/- 2.3e-02  |
 test_equilibrium_init_medres            |     -0.30 +/- 2.98     | -1.27e-02 +/- 1.25e-01 |  4.20e+00 +/- 9.8e-02  |  4.21e+00 +/- 7.8e-02  |
 test_equilibrium_init_highres           |     +3.74 +/- 2.74     | +2.09e-01 +/- 1.54e-01 |  5.80e+00 +/- 1.0e-01  |  5.59e+00 +/- 1.1e-01  |
 test_objective_compile_dshape_current   |     +1.55 +/- 1.56     | +6.10e-02 +/- 6.13e-02 |  3.99e+00 +/- 3.2e-02  |  3.93e+00 +/- 5.3e-02  |
 test_objective_compute_dshape_current   |     +0.51 +/- 1.83     | +1.82e-05 +/- 6.57e-05 |  3.62e-03 +/- 4.7e-05  |  3.60e-03 +/- 4.6e-05  |
 test_objective_jac_dshape_current       |     +3.59 +/- 9.46     | +1.46e-03 +/- 3.85e-03 |  4.22e-02 +/- 3.2e-03  |  4.07e-02 +/- 2.2e-03  |
 test_perturb_2                          |     +0.09 +/- 1.76     | +1.63e-02 +/- 3.16e-01 |  1.80e+01 +/- 1.8e-01  |  1.80e+01 +/- 2.6e-01  |
 test_proximal_freeb_jac                 |     +0.06 +/- 1.35     | +4.39e-03 +/- 1.02e-01 |  7.56e+00 +/- 7.2e-02  |  7.55e+00 +/- 7.2e-02  |
 test_solve_fixed_iter                   |     +0.63 +/- 58.29    | +3.16e-02 +/- 2.94e+00 |  5.07e+00 +/- 2.1e+00  |  5.04e+00 +/- 2.0e+00  |
 test_build_transform_fft_midres         |     +0.34 +/- 4.17     | +2.22e-03 +/- 2.71e-02 |  6.52e-01 +/- 2.0e-02  |  6.50e-01 +/- 1.8e-02  |
 test_build_transform_fft_highres        |     -2.14 +/- 3.50     | -2.22e-02 +/- 3.64e-02 |  1.02e+00 +/- 2.5e-02  |  1.04e+00 +/- 2.6e-02  |
 test_equilibrium_init_lowres            |     -4.95 +/- 3.70     | -2.08e-01 +/- 1.55e-01 |  3.99e+00 +/- 1.3e-01  |  4.20e+00 +/- 8.1e-02  |
 test_objective_compile_atf              |     -1.07 +/- 5.43     | -8.65e-02 +/- 4.38e-01 |  7.98e+00 +/- 2.6e-01  |  8.07e+00 +/- 3.5e-01  |
 test_objective_compute_atf              |     -0.34 +/- 2.40     | -3.66e-05 +/- 2.60e-04 |  1.08e-02 +/- 1.6e-04  |  1.08e-02 +/- 2.0e-04  |
 test_objective_jac_atf                  |     +2.22 +/- 1.72     | +4.42e-02 +/- 3.43e-02 |  2.03e+00 +/- 2.8e-02  |  1.99e+00 +/- 1.9e-02  |
 test_perturb_1                          |     +3.53 +/- 3.65     | +4.60e-01 +/- 4.75e-01 |  1.35e+01 +/- 1.9e-01  |  1.30e+01 +/- 4.3e-01  |
 test_proximal_jac_atf                   |     +0.12 +/- 1.19     | +9.67e-03 +/- 9.82e-02 |  8.26e+00 +/- 8.0e-02  |  8.25e+00 +/- 5.7e-02  |
 test_proximal_freeb_compute             |     -0.60 +/- 1.04     | -1.11e-03 +/- 1.92e-03 |  1.84e-01 +/- 1.6e-03  |  1.85e-01 +/- 1.0e-03  |

@ddudt ddudt requested review from f0uriest and dpanici September 26, 2024 13:59
@ddudt ddudt added the easy Short and simple to code or review label Sep 26, 2024
@ddudt ddudt merged commit 056fcc4 into master Sep 30, 2024
24 checks passed
@ddudt ddudt deleted the dd/FixOmniBmax branch September 30, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Something was fixed easy Short and simple to code or review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FixOmniBmax index error?
5 participants