Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop modding of non-periodic angles #1254

Merged
merged 4 commits into from
Sep 19, 2024

Add negative sign to residual for diagbroyden optimizer

97d1747
Select commit
Loading
Failed to load commit list.
Merged

Stop modding of non-periodic angles #1254

Add negative sign to residual for diagbroyden optimizer
97d1747
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 19, 2024 in 1s

95.45% (-0.01%) compared to 54becdb

View this Pull Request on Codecov

95.45% (-0.01%) compared to 54becdb

Details

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.45%. Comparing base (54becdb) to head (97d1747).

Files with missing lines Patch % Lines
desc/equilibrium/coords.py 95.45% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1254      +/-   ##
==========================================
- Coverage   95.45%   95.45%   -0.01%     
==========================================
  Files          95       95              
  Lines       23429    23423       -6     
==========================================
- Hits        22364    22358       -6     
  Misses       1065     1065
Files with missing lines Coverage Δ
desc/compute/_core.py 100.00% <100.00%> (ø)
desc/equilibrium/equilibrium.py 95.71% <ø> (ø)
desc/grid.py 93.07% <ø> (ø)
desc/vmec.py 91.91% <100.00%> (+<0.01%) ⬆️
desc/equilibrium/coords.py 88.42% <95.45%> (-0.33%) ⬇️

... and 2 files with indirect coverage changes

View more details on Codecov