Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take p_newton out of inner while loop #1165

Merged
merged 17 commits into from
Aug 21, 2024

Merge branch 'master' into yge/qr

7f3858d
Select commit
Loading
Failed to load commit list.
Merged

Take p_newton out of inner while loop #1165

Merge branch 'master' into yge/qr
7f3858d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 21, 2024 in 0s

95.42% (-0.02%) compared to 13108f6

View this Pull Request on Codecov

95.42% (-0.02%) compared to 13108f6

Details

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.42%. Comparing base (13108f6) to head (7f3858d).

Files Patch % Lines
desc/optimize/aug_lagrangian_ls.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1165      +/-   ##
==========================================
- Coverage   95.43%   95.42%   -0.02%     
==========================================
  Files          87       87              
  Lines       22313    22321       +8     
==========================================
+ Hits        21294    21299       +5     
- Misses       1019     1022       +3     
Files Coverage Δ
desc/optimize/least_squares.py 99.33% <100.00%> (+0.03%) ⬆️
desc/optimize/tr_subproblems.py 99.44% <ø> (-0.02%) ⬇️
desc/optimize/aug_lagrangian_ls.py 95.67% <75.00%> (-0.85%) ⬇️

... and 3 files with indirect coverage changes