Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move basis change to main compute function #1027

Merged
merged 79 commits into from
Jul 11, 2024

Merge branch 'yge/rpz2xyz' of https://github.com/PlasmaControl/DESC i…

2028c27
Select commit
Loading
Failed to load commit list.
Merged

Move basis change to main compute function #1027

Merge branch 'yge/rpz2xyz' of https://github.com/PlasmaControl/DESC i…
2028c27
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 8, 2024 in 0s

87.29% (-7.69%) compared to f187a12

View this Pull Request on Codecov

87.29% (-7.69%) compared to f187a12

Details

Codecov Report

Attention: Patch coverage is 95.89041% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.29%. Comparing base (f187a12) to head (2028c27).

❗ There is a different number of reports uploaded between BASE (f187a12) and HEAD (2028c27). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (f187a12) HEAD (2028c27)
10 8
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
- Coverage   94.97%   87.29%   -7.69%     
==========================================
  Files          87       87              
  Lines       21766    21578     -188     
==========================================
- Hits        20673    18837    -1836     
- Misses       1093     2741    +1648     
Files Coverage Δ
desc/compute/__init__.py 100.00% <ø> (ø)
desc/compute/_basis_vectors.py 98.86% <ø> (+11.75%) ⬆️
desc/compute/_surface.py 68.84% <100.00%> (-28.57%) ⬇️
desc/compute/data_index.py 96.66% <100.00%> (ø)
desc/compute/utils.py 89.35% <100.00%> (-6.84%) ⬇️
desc/equilibrium/equilibrium.py 92.18% <100.00%> (-4.12%) ⬇️
desc/geometry/core.py 89.39% <100.00%> (-6.53%) ⬇️
desc/magnetic_fields/_core.py 86.22% <100.00%> (-10.18%) ⬇️
desc/coils.py 81.81% <75.00%> (-15.09%) ⬇️
desc/compute/_curve.py 94.71% <96.29%> (-4.74%) ⬇️
... and 1 more

... and 47 files with indirect coverage changes