fix the sign error in wide QR factorization

PlasmaControl · Aug 13, 2024 · b9ba0be · b9ba0be
1 parent 5c309d8
commit b9ba0be
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/desc/optimize/tr_subproblems.py b/desc/optimize/tr_subproblems.py
@@ -421,7 +421,7 @@ def trust_region_step_exact_qr(
         p_newton = solve_triangular_regularized(R, -Q.T @ f)
     else:
         Q, R = qr(J.T, mode="economic")
-        p_newton = Q @ solve_triangular_regularized(R.T, f, lower=True)
+        p_newton = Q @ solve_triangular_regularized(R.T, -f, lower=True)
 
     def truefun(*_):
         return p_newton, False, 0.0