Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Heater Control Settings Persistent #200

Open
Tracked by #196
zCoCo opened this issue Mar 1, 2023 · 0 comments
Open
Tracked by #196

Make Heater Control Settings Persistent #200

zCoCo opened this issue Mar 1, 2023 · 0 comments
Assignees
@zCoCo
Labels
enhancement New feature or request feature-nice-to-have Not a bug fix. Not essential to mission success but is likely to make things easier. small Only several lines of code and quick to test. WD Code changes to the WatchDog
Milestone
RC9

Comments

@zCoCo
Copy link
Member

zCoCo commented Mar 1, 2023 •
edited
Loading

Makem_hParams persistent (make it static persistent and have it pointed to by WatchdogStateDetails?)
NOTE: There's a lot of stuff in this struct we don't care about (deprecated) but needs to stay there.
NOTE: This would likely require inits to CE, etc. depending on source (or we could just persist everything EXCEPT thermistor source, which is probably fine since we know BattRT works).

Sensible way to do this would be to add separate variables (or 1 separate struct) for the things we care about, persist those, and just use them to init m_hParams. Be sure to check all references to m_hParams and its children if taking this approach.
@zCoCo zCoCo mentioned this issue Mar 1, 2023
Closed
12 tasks
@zCoCo zCoCo added enhancement New feature or request feature-nice-to-have Not a bug fix. Not essential to mission success but is likely to make things easier. labels Mar 1, 2023
@zCoCo zCoCo self-assigned this Mar 1, 2023
@zCoCo zCoCo added small Only several lines of code and quick to test. WD Code changes to the WatchDog labels Mar 1, 2023
@zCoCo zCoCo modified the milestones: RC8, RC9 Mar 1, 2023
@zCoCo zCoCo changed the title Make sure m_hParams is persistent (make it static persistent and have it pointed to by WatchdogStateDetails? Make Heater Control Settings Persistent Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zCoCo zCoCo

Labels
enhancement New feature or request feature-nice-to-have Not a bug fix. Not essential to mission success but is likely to make things easier. small Only several lines of code and quick to test. WD Code changes to the WatchDog
Projects
None yet
Milestone
RC9
Development

No branches or pull requests
1 participant
@zCoCo