Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(placeos/room-events): add list_users func #461

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

w-le
Copy link
Contributor

@w-le w-le commented Sep 21, 2023

Some role based accounts running the Booking panel app (via api key) may not have MS Graph API delegated permissions to query the AAD user directory (e.g. PlaceOS local accounts).

This change allows those apps to query users via a driver exec instead of via a staff-api call. A corresponding frontend change would also be required.

@w-le w-le requested a review from stakach September 21, 2023 06:18
@w-le w-le self-assigned this Sep 21, 2023
@w-le w-le added type: driver type: enhancement new feature or request labels Sep 21, 2023
drivers/place/bookings.cr Outdated Show resolved Hide resolved
@w-le w-le requested a review from stakach September 22, 2023 06:20
@w-le
Copy link
Contributor Author

w-le commented Sep 22, 2023

tested e2e ok

@w-le w-le merged commit f126d59 into master Sep 22, 2023
2 of 5 checks passed
@w-le w-le deleted the feat/room-events_user_search branch September 22, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: driver type: enhancement new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants