Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove spec sleeps #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

caspiano
Copy link
Contributor

@caspiano caspiano commented Jul 30, 2021

There were a bunch of sleeps littered through specs.
I think we should try to avoid these entirely.
if they are necessary, we should implement some kind of asynchronous abstraction or make requests synchronous.

@caspiano caspiano force-pushed the refactor/remove-spec-sleeps branch from dcb2585 to a8beff8 Compare August 3, 2021 01:50
@caspiano caspiano force-pushed the refactor/remove-spec-sleeps branch from a8beff8 to 3a3e4d9 Compare August 3, 2021 01:52
@caspiano caspiano marked this pull request as ready for review August 3, 2021 01:52
@kimburgess
Copy link
Contributor

Responses from exec's can be awaiting by calling #get on their result, which blocks until the Future resolves. One that I've defined run into (and had to insert a sleep to accomodate) is the initial init / settings load.

This change is definitely the correct thing to do, but will need to be synchronised with improvements to spec-runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants