Skip to content
CI

fix(modes/system): allow version to be updated #82

Sign in to view logs

fix(modes/system): allow version to be updated

fix(modes/system): allow version to be updated #82

GitHub Actions / Ameba failed Sep 5, 2024 in 0s

Crystal Ameba Results

Total files checked: 75
Issues found: 23

Ameba Version: 1.6.1
Crystal Version: 1.10.0

Annotations

Check notice on line 34 in src/placeos/api/models/driver.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods 

Consider using 'getter?' for 'ignore_connected'
Raw output 
> getter ignore_connected : Bool
         ^

Check warning on line 27 in src/placeos/api/models/websocket/response.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Documentation/DocumentationAdmonition 

Found a FIXME admonition in a comment
Raw output 
> # FIXME: currently this is parsing twice - this is a quick hack to get things
  ^

Check warning on line 26 in src/placeos/api_wrapper.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Documentation/DocumentationAdmonition 

Found a TODO admonition in a comment
Raw output 
> # TODO:
  ^

Check warning on line 40 in src/placeos/api_wrapper.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Lint/MissingBlockArgument 

Missing anonymous block argument. Use `&` as an argument name to indicate yielding method.
Raw output 
> def connection
      ^

Check notice on line 13 in src/placeos/api/models/oauth_application.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods 

Consider using 'getter?' for 'skip_authorization'
Raw output 
> getter skip_authorization : Bool
         ^

Check notice on line 14 in src/placeos/api/models/oauth_application.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods 

Consider using 'getter?' for 'confidential'
Raw output 
> getter confidential : Bool
         ^

Check notice on line 31 in src/placeos/api/models/module.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods 

Consider using 'getter?' for 'makebreak'
Raw output 
> getter makebreak : Bool
         ^

Check notice on line 48 in src/placeos/api/models/module.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods 

Consider using 'getter?' for 'connected'
Raw output 
> getter connected : Bool
         ^

Check notice on line 51 in src/placeos/api/models/module.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods 

Consider using 'getter?' for 'running'
Raw output 
> getter running : Bool
         ^

Check notice on line 54 in src/placeos/api/models/module.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods 

Consider using 'getter?' for 'ignore_connected'
Raw output 
> getter ignore_connected : Bool
         ^

Check notice on line 58 in src/placeos/api/models/module.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods 

Consider using 'getter?' for 'ignore_startstop'
Raw output 
> getter ignore_startstop : Bool
         ^

Check notice on line 50 in src/placeos/api/models/system.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods 

Consider using 'getter?' for 'bookable'
Raw output 
> getter bookable : Bool
         ^

Check warning on line 22 in src/placeos/api/models/asset.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Documentation/DocumentationAdmonition 

Found a TODO admonition in a comment
Raw output 
> # TODO: define currency for `purchase_price`
  ^

Check notice on line 18 in src/placeos/api/models/asset_instance.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods 

Consider using 'getter?' for 'approval'
Raw output 
> getter approval : Bool
         ^

Check notice on line 14 in src/placeos/api/models/trigger.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods 

Consider using 'getter?' for 'important'
Raw output 
> getter important : Bool
         ^

Check notice on line 16 in src/placeos/api/models/trigger.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods 

Consider using 'getter?' for 'enable_webhook'
Raw output 
> getter enable_webhook : Bool
         ^

Check notice on line 9 in src/placeos/api/models/trigger_instance.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods 

Consider using 'getter?' for 'enabled'
Raw output 
> getter enabled : Bool = true
         ^

Check notice on line 10 in src/placeos/api/models/trigger_instance.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods 

Consider using 'getter?' for 'triggered'
Raw output 
> getter triggered : Bool = false
         ^

Check notice on line 11 in src/placeos/api/models/trigger_instance.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods 

Consider using 'getter?' for 'important'
Raw output 
> getter important : Bool = false
         ^

Check notice on line 12 in src/placeos/api/models/trigger_instance.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods 

Consider using 'getter?' for 'exec_enabled'
Raw output 
> getter exec_enabled : Bool = false
         ^

Check notice on line 6 in src/placeos/api/models/ping.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Naming/QueryBoolMethods 

Consider using 'getter?' for 'pingable'
Raw output 
> getter pingable : Bool
         ^

Check warning on line 4 in src/placeos/api_wrapper/users.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Documentation/DocumentationAdmonition 

Found a TODO admonition in a comment
Raw output 
> # TODO:
  ^

Check warning on line 32 in src/placeos/client.cr

See this annotation in the file changed.

@github-actions github-actions / Ameba

Lint/MissingBlockArgument 

Missing anonymous block argument. Use `&` as an argument name to indicate yielding method.
Raw output 
> def self.from_environment_user
           ^
View more details on GitHub Actions