Skip to content
CI

fix(model/driver): mark fields as optional #79

Sign in to view logs

fix(model/driver): mark fields as optional

fix(model/driver): mark fields as optional #79

Triggered via push September 5, 2024 03:09
@stakachstakach
pushed 4560da9
master
Status Failure
Total duration 1m 45s
Artifacts –

ci.yml

on: push
style  /  crystal-style
1m 27s
style / crystal-style
Matrix: spec
Fit to window
Zoom out
Zoom in

Annotations

2 errors, 10 warnings, and 17 notices
spec (nightly, true)
Process completed with exit code 127.
spec (false, 1.3.2)
Process completed with exit code 1.
spec (nightly, true)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Documentation/DocumentationAdmonition: src/placeos/api_wrapper.cr#L26
Found a TODO admonition in a comment
Lint/MissingBlockArgument: src/placeos/api_wrapper.cr#L40
Missing anonymous block argument. Use `&` as an argument name to indicate yielding method.
Documentation/DocumentationAdmonition: src/placeos/api/models/websocket/response.cr#L27
Found a FIXME admonition in a comment
Documentation/DocumentationAdmonition: src/placeos/api/models/asset.cr#L22
Found a TODO admonition in a comment
Documentation/DocumentationAdmonition: src/placeos/api_wrapper/users.cr#L4
Found a TODO admonition in a comment
Lint/MissingBlockArgument: src/placeos/client.cr#L32
Missing anonymous block argument. Use `&` as an argument name to indicate yielding method.
style / crystal-style
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
spec (false, 1.3.2)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
spec (false, latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Naming/QueryBoolMethods: src/placeos/api/models/driver.cr#L34
Consider using 'getter?' for 'ignore_connected'
Naming/QueryBoolMethods: src/placeos/api/models/oauth_application.cr#L13
Consider using 'getter?' for 'skip_authorization'
Naming/QueryBoolMethods: src/placeos/api/models/oauth_application.cr#L14
Consider using 'getter?' for 'confidential'
Naming/QueryBoolMethods: src/placeos/api/models/system.cr#L50
Consider using 'getter?' for 'bookable'
Naming/QueryBoolMethods: src/placeos/api/models/module.cr#L31
Consider using 'getter?' for 'makebreak'
Naming/QueryBoolMethods: src/placeos/api/models/module.cr#L48
Consider using 'getter?' for 'connected'
Naming/QueryBoolMethods: src/placeos/api/models/module.cr#L51
Consider using 'getter?' for 'running'
Naming/QueryBoolMethods: src/placeos/api/models/module.cr#L54
Consider using 'getter?' for 'ignore_connected'
Naming/QueryBoolMethods: src/placeos/api/models/module.cr#L58
Consider using 'getter?' for 'ignore_startstop'
Naming/QueryBoolMethods: src/placeos/api/models/asset_instance.cr#L18
Consider using 'getter?' for 'approval'
Naming/QueryBoolMethods: src/placeos/api/models/trigger_instance.cr#L9
Consider using 'getter?' for 'enabled'
Naming/QueryBoolMethods: src/placeos/api/models/trigger_instance.cr#L10
Consider using 'getter?' for 'triggered'
Naming/QueryBoolMethods: src/placeos/api/models/trigger_instance.cr#L11
Consider using 'getter?' for 'important'
Naming/QueryBoolMethods: src/placeos/api/models/trigger_instance.cr#L12
Consider using 'getter?' for 'exec_enabled'
Naming/QueryBoolMethods: src/placeos/api/models/trigger.cr#L14
Consider using 'getter?' for 'important'
Naming/QueryBoolMethods: src/placeos/api/models/ping.cr#L6
Consider using 'getter?' for 'pingable'
Naming/QueryBoolMethods: src/placeos/api/models/trigger.cr#L16
Consider using 'getter?' for 'enable_webhook'